close sqlite connection

Author: danlu1

synapseclient/models/services/migration.py

@@ -1406,8 +1406,9 @@ async def migrate_indexed_files_async(
     client = Synapse.get_client(synapse_client=synapse_client)
 
     # Retrieve settings
-    with sqlite3.connect(db_path, check_same_thread=False) as conn:
-        cursor = conn.cursor()
+    conn = sqlite3.connect(db_path, check_same_thread=False)
+    cursor = conn.cursor()
+    try:
         _ensure_schema(cursor)
         existing_settings = _retrieve_index_settings(cursor)
         if existing_settings is None:
@@ -1436,6 +1437,8 @@ async def migrate_indexed_files_async(
             synapse_client=client,
         )
         return MigrationResult(db_path=db_path, synapse_client=client)
+    finally:
+        conn.close()
 
 
 async def _execute_migration_async(

tests/unit/synapseclient/services/unit_test_migration_and_types_async.py

@@ -2348,13 +2348,16 @@ async def test_returns_none_when_migration_not_confirmed(
     ):
         path, _ = db_file_with_settings
         # Add an indexed row so there's something to confirm
-        with sqlite3.connect(path) as conn:
+        conn = sqlite3.connect(path)
+        try:
             cursor = conn.cursor()
             cursor.execute(
                 "INSERT INTO migrations (id, type, status) VALUES (?, ?, ?)",
                 ("syn3", MigrationType.FILE.value, MigrationStatus.INDEXED.value),
             )
             conn.commit()
+        finally:
+            conn.close()
 
         client = _make_mock_client()
         with (