Skip to content

Commit 3568ee8

Browse files
committed
linglings suggestions
1 parent 33415e0 commit 3568ee8

4 files changed

Lines changed: 211 additions & 109 deletions

File tree

CLAUDE.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ pip install -e ".[docs]" && mkdocs serve
3636

3737
## Conventions
3838

39-
### Docstring style
40-
Do not use backticks (single or double) in docstrings. Write parameter names, method names, and values as plain text.
41-
4239
### Docstring examples format
4340
Use mkdocstrings admonition syntax. Start with a description line, then wrap code in a fenced python block. Examples should use sync methods (not async) and include login boilerplate. See evaluation.py for reference.
4441

synapseclient/models/download_list.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -449,8 +449,9 @@ async def _download_manifest_file(
449449
does not abort the entire batch.
450450
451451
Arguments:
452-
row: A manifest row dict. Must contain "ID" and "versionNumber"
453-
keys. Modified in place to add "path" and "error" entries.
452+
row: A manifest row dict. Must contain an "ID" key; "versionNumber"
453+
is optional and defaults to the latest version when missing or
454+
blank. Modified in place to add "path" and "error" entries.
454455
download_location: Directory to download the file to. Defaults to
455456
the Synapse cache location if None.
456457
synapse_client: Optional Synapse client. Uses cached singleton if omitted.
@@ -466,13 +467,6 @@ async def _download_manifest_file(
466467
version_str = row.get(_VERSION_COLUMN)
467468
version_number = int(version_str) if version_str else None
468469

469-
if version_number is None:
470-
msg = f"Manifest row for {entity_id} is missing versionNumber"
471-
row[_PATH_COLUMN] = ""
472-
row[_ERROR_COLUMN] = msg
473-
client.logger.warning(msg)
474-
return None
475-
476470
try:
477471
file = await File(
478472
id=entity_id,

0 commit comments

Comments
 (0)