@@ -71,8 +71,6 @@ async def test_missing_parent_id_column_raises(self, tmp_path: Path) -> None:
7171 with pytest .raises (ValueError , match = "'parentId'" ):
7272 await read_manifest_for_upload (str (manifest ), self .syn , True , False )
7373
74- # -- error column handling ---------------------------------------------
75-
7674 async def test_rows_with_error_are_skipped (self , tmp_path : Path ) -> None :
7775 """Rows with a non-empty 'error' cell are excluded from the returned items list."""
7876 f = tmp_path / "file.txt"
@@ -97,8 +95,6 @@ async def test_all_rows_have_errors_returns_empty(self, tmp_path: Path) -> None:
9795 assert items == []
9896 assert total == 0
9997
100- # -- path validation ---------------------------------------------------
101-
10298 async def test_duplicate_paths_raise (self , tmp_path : Path ) -> None :
10399 """Two rows referencing the same file path raise ValueError about unique file paths."""
104100 f = tmp_path / "file.txt"
@@ -125,8 +121,6 @@ async def test_empty_file_raises(self, tmp_path: Path) -> None:
125121 with pytest .raises (ValueError , match = "empty" ):
126122 await read_manifest_for_upload (str (manifest ), self .syn , True , False )
127123
128- # -- successful upload items -------------------------------------------
129-
130124 async def test_valid_manifest_returns_items_and_size (self , tmp_path : Path ) -> None :
131125 """A valid manifest returns one upload item and the correct total file size."""
132126 f = tmp_path / "file.txt"
@@ -552,7 +546,7 @@ def test_valid_names_pass(self) -> None:
552546 "parentId" : ["syn1" , "syn1" ],
553547 }
554548 )
555- _check_file_names (df ) # should not raise
549+ _check_file_names (df )
556550
557551 def test_invalid_name_raises (self ) -> None :
558552 """A file name containing characters not permitted by Synapse raises ValueError."""
@@ -587,7 +581,7 @@ def test_same_name_different_parent_is_ok(self) -> None:
587581 "parentId" : ["syn1" , "syn2" ],
588582 }
589583 )
590- _check_file_names (df ) # should not raise
584+ _check_file_names (df )
591585
592586 @pytest .mark .parametrize (
593587 "name" ,
@@ -608,7 +602,7 @@ def test_special_characters_in_name_accepted(self, name: str) -> None:
608602 "parentId" : ["syn1" ],
609603 }
610604 )
611- _check_file_names (df ) # should not raise
605+ _check_file_names (df )
612606
613607
614608class TestSortAndFixProvenance :
0 commit comments