Performance improvements for ValueHelper

- Put more common types higher up the if-else clause
- Use a constant regex instead of creating a new one on every call
- Avoid calling .to_s.downcase repeatedly:
    - Extract into single `#to_s` call
    - Let regex match in case-insensitive mode

Author: guille-work

lib/class_kit.rb

@@ -1,3 +1,4 @@
+require_relative 'class_kit/constants'
 require_relative 'class_kit/class_methods'
 require_relative 'class_kit/exceptions'
 require_relative 'class_kit/attribute_helper'
@@ -10,4 +11,3 @@
 require 'date'
 require 'bigdecimal'
 require 'time'
-

lib/class_kit/constants.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module ClassKit
+  module Constants
+    # Shared constants, to avoid re-creating them on each call to helper methods.
+    BOOL_TRUE_RE  = /\A(?:true|t|yes|y|1)\z/i
+    BOOL_FALSE_RE = /\A(?:false|f|no|n|0)\z/i
+  end
+end

lib/class_kit/value_helper.rb

@@ -1,39 +1,19 @@
 module ClassKit
   class ValueHelper
-
     def self.instance
       @@instance ||= new
     end
 
     def parse(type:, value:)
-      if type == Time
-        if value.is_a?(Time)
-          value
-        elsif value.is_a?(Integer) || value.is_a?(Float) || value.is_a?(BigDecimal)
-          Time.at(value)
-        else
-          Time.parse(value)
-        end
-      elsif type == Date
-        if value.is_a?(Date)
-          value
-        else
-          Date.parse(value)
-        end
-      elsif type == DateTime
-        if value.is_a?(DateTime)
-          value
-        else
-          DateTime.parse(value)
-        end
-      elsif type == :bool
-        if value == true || value == false
-          value
-        elsif(/(true|t|yes|y|1)$/i === value.to_s.downcase)
+      if type == :bool
+        return value if value == true || value == false
+
+        s = value.to_s
+        if Constants::BOOL_TRUE_RE.match?(s)
           true
-        elsif (/(false|f|no|n|0)$/i === value.to_s.downcase)
+        elsif Constants::BOOL_FALSE_RE.match?(s)
           false
-        elsif value != nil
+        elsif !value.nil?
           raise 'Unable to parse bool'
         end
       elsif type == Integer
@@ -44,26 +24,41 @@ def parse(type:, value:)
         if value.is_a?(BigDecimal)
           value
         else
-          value = value.to_s
-          raise 'Unable to parse BigDecimal' unless value =~ /\A-?\d+(\.\d*)?/
-          BigDecimal(value)
+          s = value.to_s
+          raise 'Unable to parse BigDecimal' unless s =~ /\A-?\d+(\.\d*)?/
+
+          BigDecimal(s)
         end
       elsif type == String
         String(value)
+      elsif type == Time
+        if value.is_a?(Time)
+          value
+        elsif value.is_a?(Integer) || value.is_a?(Float) || value.is_a?(BigDecimal)
+          Time.at(value)
+        else
+          Time.parse(value)
+        end
+      elsif type == Date
+        value.is_a?(Date) ? value : Date.parse(value)
+      elsif type == DateTime
+        value.is_a?(DateTime) ? value : DateTime.parse(value)
       elsif type == Regexp
         Regexp.new(value)
       elsif type == Hash
         raise 'Unable to parse Hash' unless value.is_a?(Hash)
+
         value
       elsif type == Array
         raise 'Unable to parse Array' unless value.is_a?(Array)
+
         value
       elsif type.include?(ClassKit::CustomType)
         type.parse_assign(value)
       else
         raise 'Unable to parse'
       end
-    rescue => e
+    rescue StandardError => e
       raise ClassKit::Exceptions::InvalidParseValueError,
             "Unable to parse value: #{value} into type: #{type}. Error: #{e}"
     end