Fix test and skip code coverage

Author: SeeminglyScience

ClassExplorer.build.ps1

@@ -10,16 +10,6 @@ param(
     [switch] $Force
 )
 
-$moduleName = 'ClassExplorer'
-$testModuleManifestSplat = @{
-    ErrorAction   = 'Ignore'
-    WarningAction = 'Ignore'
-    Path          = "$PSScriptRoot\module\$moduleName.psd1"
-}
-
-$manifest = Test-ModuleManifest @testModuleManifestSplat
-$moduleVersion = $manifest.Version
-
 $tools = "$PSScriptRoot\tools"
 $script:GetDotNet = Get-Command $tools\GetDotNet.ps1
 $script:AssertModule = Get-Command $tools\AssertRequiredModule.ps1
@@ -93,6 +83,7 @@ task GetProjectInfo {
 
     $manifest = Test-ModuleManifest @testModuleManifestSplat
     $script:ModuleVersion = $manifest.Version
+    $script:ReleasePath = "./Release/$script:ModuleName/$script:ModuleVersion"
     $script:_IsWindows = $true
     $runtimeInfoType = 'System.Runtime.InteropServices.RuntimeInformation' -as [type]
     try {
@@ -132,7 +123,7 @@ task Clean {
 }
 
 task BuildDocs -If { Test-Path ./docs/$PSCulture/*.md } {
-    $releaseDocs = "./Release/ClassExplorer/$moduleVersion"
+    $releaseDocs = $script:ReleasePath
     $null = New-Item $releaseDocs/$PSCulture -ItemType Directory -Force -ErrorAction Ignore
     $null = New-ExternalHelp -Path ./docs/$PSCulture -OutputPath $releaseDocs/$PSCulture
 
@@ -153,15 +144,15 @@ task CopyToRelease  {
     $modern = $script:ModernTarget
     $legacy = $script:LegacyTarget
 
-    $releasePath = "./Release/ClassExplorer/$version"
-    if (-not (Test-Path -LiteralPath $releasePath)) {
-        $null = New-Item $releasePath -ItemType Directory
+    $release = $script:ReleasePath
+    if (-not (Test-Path -LiteralPath $release)) {
+        $null = New-Item $release -ItemType Directory
     }
 
-    Copy-Item -Path ./module/* -Destination $releasePath -Recurse -Force
+    Copy-Item -Path ./module/* -Destination $release -Recurse -Force
 
     if ($script:_IsWindows) {
-        $null = New-Item $releasePath/bin/Legacy -Force -ItemType Directory
+        $null = New-Item $release/bin/Legacy -Force -ItemType Directory
         $legacyFiles = (
             'ClassExplorer.dll',
             'ClassExplorer.pdb',
@@ -172,17 +163,17 @@ task CopyToRelease  {
             'System.Runtime.CompilerServices.Unsafe.dll')
 
         foreach ($file in $legacyFiles) {
-            Copy-Item -Force -LiteralPath ./artifacts/publish/ClassExplorer/${Configuration}_$legacy/$file -Destination $releasePath/bin/Legacy
+            Copy-Item -Force -LiteralPath (GetArtifactPath -FileName $file -Legacy) -Destination $release/bin/Legacy
         }
     }
 
-    $null = New-Item $releasePath/bin/Modern -Force -ItemType Directory
+    $null = New-Item $release/bin/Modern -Force -ItemType Directory
     $modernFiles = (
         'ClassExplorer.dll',
         'ClassExplorer.pdb',
         'ClassExplorer.deps.json')
     foreach ($file in $modernFiles) {
-        Copy-Item -Force -LiteralPath ./artifacts/publish/ClassExplorer/${Configuration}_$modern/$file -Destination $releasePath/bin/Modern
+        Copy-Item -Force -LiteralPath (GetArtifactPath -FileName $file) -Destination $release/bin/Modern
     }
 }
 
@@ -210,19 +201,21 @@ task DoTest -If { Test-Path ./test/*.ps1 } {
         $powershellCommand = 'pwsh'
     }
 
-    $powershell = (Get-Command -CommandType Application $powershellCommand).Source
+    $powershell = Get-Command -CommandType Application $powershellCommand | Select-Object -First 1 -ExpandProperty Source
 
+    # Can't be bothered atm, gotta modernize this at some point.
+    $GenerateCodeCoverage = $false
     if ($GenerateCodeCoverage.IsPresent) {
         # OpenCover needs full pdb's. I'm very open to suggestions for streamlining this...
         # & $dotnet clean
         & $dotnet publish --configuration $Configuration --framework $script:LegacyTarget --verbosity quiet --nologo /p:DebugType=Full
 
         $moduleName = $Settings.Name
-        $release = '{0}\bin\Desktop\{1}' -f $Folders.Release, $moduleName
-        $coverage = '{0}\net471\{1}' -f $Folders.Build, $moduleName
+        $release = "$script:ReleasePath/bin/Legacy/$script:ModuleName"
+        $coverage = GetArtifactPath -Legacy $script:ModuleName
 
-        Rename-Item "$release.pdb" -NewName "$moduleName.pdb.tmp"
-        Rename-Item "$release.dll" -NewName "$moduleName.dll.tmp"
+        Rename-Item "$release.pdb" -NewName "$script:ModuleName.pdb.tmp"
+        Rename-Item "$release.dll" -NewName "$script:ModuleName.dll.tmp"
         Copy-Item "$coverage.pdb" "$release.pdb"
         Copy-Item "$coverage.dll" "$release.dll"
 
@@ -236,8 +229,8 @@ task DoTest -If { Test-Path ./test/*.ps1 } {
 
         Remove-Item "$release.pdb"
         Remove-Item "$release.dll"
-        Rename-Item "$release.pdb.tmp" -NewName "$moduleName.pdb"
-        Rename-Item "$release.dll.tmp" -NewName "$moduleName.dll"
+        Rename-Item "$release.pdb.tmp" -NewName "$script:ModuleName.pdb"
+        Rename-Item "$release.dll.tmp" -NewName "$script:ModuleName.dll"
     } else {
         & $powershell -NoProfile -EncodedCommand $encodedCommand
     }

test/Find-Member.Tests.ps1

@@ -165,13 +165,24 @@ Describe 'Find-Member cmdlet tests' {
     }
 
     It 'gets members for passed objects only once per type' {
-        $powershells = [powershell]::Create(), [powershell]::Create()
-        try {
-            $result = $powershells | Find-Member
-        } finally {
-            $powershells.ForEach('Dispose')
-        }
+        $type = compile '
+            public static void StaticMethod() { }
+
+            public static int StaticProperty { get; set; }
+
+            public static int StaticField;
+
+            public static event System.EventHandler StaticEvent;
+
+            public void InstanceMethod() { }
+
+            public int InstanceProperty { get; set; }
+
+            public int InstanceField;
+
+            public event System.EventHandler InstanceEvent;'
 
-        $result.Where{ $_.Name -eq 'Create' }.Count | Should -Be 3
+        $instances = $type::new(), $type::new()
+        $instances | Find-Member | Where-Object Name -eq InstanceMethod | Should -HaveCount 1
     }
 }