Skip to content

Commit 3edeede

Browse files
committed
added some missing logging in RestApi [see #127]
1 parent 30cd404 commit 3edeede

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

  • src/main/java/de/unirostock/sems/cbarchive/web/rest

src/main/java/de/unirostock/sems/cbarchive/web/rest/RestApi.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -367,8 +367,10 @@ public Response deleteWorkspace( @CookieParam(Fields.COOKIE_PATH) String userPat
367367
history.getRecentWorkspaces().add( user.getWorkspace() );
368368
history.setCurrentWorkspace( user.getWorkspaceId() );
369369

370-
if( workspaceId == null || workspaceId.isEmpty() )
370+
if( workspaceId == null || workspaceId.isEmpty() ) {
371+
LOGGER.error("No workspace id was provided for deletion");
371372
return buildErrorResponse(400, user, "No workspace ID provided");
373+
}
372374

373375
// removes workspace
374376
history.removeWorkspaceFromHistory(workspaceId);
@@ -433,8 +435,10 @@ public Response updateOwnVcard( @CookieParam(Fields.COOKIE_PATH) String userPath
433435
user.setData(data);
434436
return buildResponse(200, user).entity(user.getData()).build();
435437
}
436-
else
438+
else {
439+
LOGGER.warn("User ", user.getWorkspaceId(), " has provided insufficient information to update vCard");
437440
return buildErrorResponse(400, user, "insufficient user information");
441+
}
438442
}
439443

440444
// --------------------------------------------------------------------------------
@@ -1077,8 +1081,10 @@ public Response deleteArchiveEntry( @PathParam("archive_id") String archiveId, @
10771081

10781082
if( result )
10791083
return buildResponse(200, user).entity("ok").build();
1080-
else
1084+
else {
1085+
LOGGER.error("Cannot move meta description for entry ", entryId, " in Archive ", archiveId, " in Workspace ", user.getWorkspaceId());
10811086
return buildErrorResponse(500, user, "Cannot remove meta description");
1087+
}
10821088
} catch (TransformerException e) {
10831089
LOGGER.error(e, MessageFormat.format("Cannot pack archive {0} entries in WorkingDir {1}", archiveId, user.getWorkingDir()) );
10841090
return buildErrorResponse( 500, user, "Cannot delete meta info", "Cannot pack archive " + archiveId + " entries in WorkingDir " + user.getWorkingDir().toString(), e.getMessage() );
@@ -1369,8 +1375,10 @@ public Response deleteMetaObject( @PathParam("archive_id") String archiveId, @Pa
13691375

13701376
if( result )
13711377
return buildResponse(200, user).entity("ok").build();
1372-
else
1378+
else {
1379+
LOGGER.error("Cannot remove meta description for entry ", entryId, " in Archive ", archiveId, " in Workspace ", user.getWorkspaceId());
13731380
return buildErrorResponse(500, user, "Cannot remove meta description");
1381+
}
13741382
} catch (TransformerException e) {
13751383
LOGGER.error(e, MessageFormat.format("Cannot pack archive {0} entries in WorkingDir {1}", archiveId, user.getWorkingDir()) );
13761384
return buildErrorResponse( 500, user, "Cannot delete meta info", "Cannot pack archive " + archiveId + " entries in WorkingDir " + user.getWorkingDir().toString(), e.getMessage() );

0 commit comments

Comments
 (0)