fix: remove TTY flag and add error checking in load test

- Remove -t flag from kubectl run (no TTY in CI)
- Add exit code check to fail if load test pod errors
- Fixes false positive "Tests passed" when uploads actually failed

Author: ServerSideHannes

.github/workflows/helm-install-test.yml

@@ -119,6 +119,8 @@ jobs:
             --set redis-ha.enabled=false \
             --set externalRedis.url="redis://redis:6379/0" \
             --set replicaCount=3 \
+            --set resources.limits.cpu=100m \
+            --set resources.requests.cpu=50m \
             --wait \
             --timeout 5m
 

e2e/cluster.sh

@@ -50,7 +50,7 @@ case "${1:-run}" in
       done
 
       echo "=== Creating test pod with AWS CLI ==="
-      kubectl run s3-load-test -n s3proxy --rm -it --restart=Never \
+      kubectl run s3-load-test -n s3proxy --rm -i --restart=Never \
         --image=amazon/aws-cli:latest \
         --env="AWS_ACCESS_KEY_ID=minioadmin" \
         --env="AWS_SECRET_ACCESS_KEY=minioadmin" \
@@ -174,6 +174,12 @@ case "${1:-run}" in
           fi
         "
 
+      LOAD_TEST_EXIT=$?
+      if [ $LOAD_TEST_EXIT -ne 0 ]; then
+        echo "✗ Load test failed with exit code $LOAD_TEST_EXIT"
+        exit 1
+      fi
+
       # Verify load balancing
       echo ""
       echo "=== Checking load balancing ==="