Skip to content

Commit 91bdc78

Browse files
committed
removed title from angular app.ts, increased MAX_ADD_TIME
1 parent cd66ee7 commit 91bdc78

3 files changed

Lines changed: 27 additions & 7 deletions

File tree

src/__testing__/mock/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { ANGULAR_JSON_FILE_NAME, ANGULAR_ROUTES_FILE_NAME, APP_CONFIG_FILE_NAME,
33
import { OmitStrict } from '../../types';
44
import { getPath, Path } from '../../utilities';
55

6-
export const MAX_ADD_TIME: number = 90000;
6+
export const MAX_ADD_TIME: number = 100000;
77

88
export const MAX_GEN_CODE_TIME: number = 10000;
99

src/commands/add/add-angular-website/add-angular-website.command.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { AngularUtilities, NavElementTypes } from '../../../angular';
2-
import { ANGULAR_JSON_FILE_NAME, APPS_DIRECTORY_NAME, BASE_TS_CONFIG_FILE_NAME, DOCKER_FILE_NAME, GIT_IGNORE_FILE_NAME } from '../../../constants';
2+
import { ANGULAR_APP_COMPONENT_FILE_NAME, ANGULAR_JSON_FILE_NAME, APPS_DIRECTORY_NAME, BASE_TS_CONFIG_FILE_NAME, DOCKER_FILE_NAME, GIT_IGNORE_FILE_NAME } from '../../../constants';
33
import { DockerUtilities } from '../../../docker';
44
import { FsUtilities, JsonUtilities, QuestionsFor } from '../../../encapsulation';
55
import { DefaultEnvKeys, EnvUtilities } from '../../../env';
@@ -82,7 +82,7 @@ export class AddAngularWebsiteCommand extends BaseAddCommand<AddAngularWebsiteCo
8282

8383
await AngularUtilities.addSitemapAndRobots(root, config.name, domain);
8484

85-
await this.cleanUp(root);
85+
await this.cleanUp(root, config.name);
8686
await this.setupTsConfig(root, config.name);
8787
await this.createDockerfile(root, config);
8888
await AngularUtilities.setupNavigation(root, config.name);
@@ -222,9 +222,19 @@ export class AddAngularWebsiteCommand extends BaseAddCommand<AddAngularWebsiteCo
222222
await FsUtilities.createFile(getPath(root, 'tsconfig.eslint.json'), JsonUtilities.stringify(eslintTsconfig));
223223
}
224224

225-
private async cleanUp(root: string): Promise<void> {
225+
private async cleanUp(root: string, name: string): Promise<void> {
226226
// eslint-disable-next-line no-console
227227
console.log('cleans up');
228+
await FsUtilities.replaceInFile(
229+
getPath(root, 'src', 'app', ANGULAR_APP_COMPONENT_FILE_NAME),
230+
`protected readonly title = signal('${name}');`,
231+
' constructor() {}'
232+
);
233+
await FsUtilities.replaceInFile(
234+
getPath(root, 'src', 'app', ANGULAR_APP_COMPONENT_FILE_NAME),
235+
'Component, signal',
236+
'Component'
237+
);
228238
await FsUtilities.rm(getPath(root, '.vscode'));
229239
await FsUtilities.rm(getPath(root, '.editorconfig'));
230240
await FsUtilities.rm(getPath(root, GIT_IGNORE_FILE_NAME));

src/commands/add/add-angular/add-angular.command.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable no-console */
22
import { AngularUtilities, NavElementTypes } from '../../../angular';
3-
import { ANGULAR_JSON_FILE_NAME, APP_CONFIG_FILE_NAME, APPS_DIRECTORY_NAME, BASE_TS_CONFIG_FILE_NAME, DOCKER_FILE_NAME, GIT_IGNORE_FILE_NAME } from '../../../constants';
3+
import { ANGULAR_APP_COMPONENT_FILE_NAME, ANGULAR_JSON_FILE_NAME, APP_CONFIG_FILE_NAME, APPS_DIRECTORY_NAME, BASE_TS_CONFIG_FILE_NAME, DOCKER_FILE_NAME, GIT_IGNORE_FILE_NAME } from '../../../constants';
44
import { DockerUtilities } from '../../../docker';
55
import { FsUtilities, JsonUtilities, QuestionsFor } from '../../../encapsulation';
66
import { DefaultEnvKeys, EnvUtilities } from '../../../env';
@@ -72,7 +72,7 @@ export class AddAngularCommand extends BaseAddCommand<AddAngularConfiguration> {
7272
const config: AddAngularConfiguration = await this.getConfig();
7373
const root: Path = await this.createProject(config);
7474
await Promise.all([
75-
this.cleanUp(root),
75+
this.cleanUp(root, config.name),
7676
this.setupTsConfig(root, config.name),
7777
this.createDockerfile(root, config),
7878
EslintUtilities.setupProjectEslint(root, true),
@@ -254,8 +254,18 @@ export class AddAngularCommand extends BaseAddCommand<AddAngularConfiguration> {
254254
return newProject.path;
255255
}
256256

257-
private async cleanUp(root: string): Promise<void> {
257+
private async cleanUp(root: string, name: string): Promise<void> {
258258
console.log('cleans up');
259+
await FsUtilities.replaceInFile(
260+
getPath(root, 'src', 'app', ANGULAR_APP_COMPONENT_FILE_NAME),
261+
`protected readonly title = signal('${name}');`,
262+
' constructor() {}'
263+
);
264+
await FsUtilities.replaceInFile(
265+
getPath(root, 'src', 'app', ANGULAR_APP_COMPONENT_FILE_NAME),
266+
'Component, signal',
267+
'Component'
268+
);
259269
await FsUtilities.rm(getPath(root, '.vscode'));
260270
await FsUtilities.rm(getPath(root, '.editorconfig'));
261271
await FsUtilities.rm(getPath(root, GIT_IGNORE_FILE_NAME));

0 commit comments

Comments
 (0)