Add join testing of implicit join based on Aliased conventions

Author: mythz

src/ServiceStack.OrmLite.Firebird/FirebirdOrmLiteDialectProvider.cs

@@ -713,7 +713,6 @@ public override string GetQuotedTableName(string tableName)
             return Quote(NamingStrategy.GetTableName(tableName));
         }
 
-
         public override string GetQuotedColumnName(string fieldName)
         {
             return Quote(NamingStrategy.GetColumnName(fieldName));

tests/ServiceStack.OrmLite.Tests/LoadReferencesJoinTests.cs

@@ -292,5 +292,75 @@ public void Can_do_LeftJoins_using_SqlExpression()
             Assert.That(dbAddresses.Count, Is.EqualTo(3));
         }
 
+        [Test]
+        public void Can_Join_on_matching_Alias_convention()
+        {
+            db.DropAndCreateTable<AliasedCustomer>();
+            db.DropAndCreateTable<AliasedCustomerAddress>();
+
+            var customers = new[]
+            {
+                new AliasedCustomer
+                {
+                    Name = "Customer 1",
+                    PrimaryAddress = new AliasedCustomerAddress {
+                        AddressLine1 = "1 Australia Street",
+                        Country = "Australia"
+                    },
+                },
+                new AliasedCustomer
+                {
+                    Name = "Customer 2",
+                    PrimaryAddress = new AliasedCustomerAddress {
+                        AddressLine1 = "2 America Street",
+                        Country = "USA"
+                    },
+                },
+                new AliasedCustomer
+                {
+                    Name = "Customer 3",
+                    PrimaryAddress = new AliasedCustomerAddress {
+                        AddressLine1 = "3 Canada Street",
+                        Country = "Canada"
+                    },
+                },
+            };
+
+            customers.Each(c =>
+                db.Save(c, references: true));
+
+            db.Insert(
+                new Country { CountryName = "Australia", CountryCode = "AU" },
+                new Country { CountryName = "USA", CountryCode = "US" },
+                new Country { CountryName = "Italy", CountryCode = "IT" },
+                new Country { CountryName = "Spain", CountryCode = "ED" });
+
+            //Normal Join
+            var dbCustomers = db.Select<AliasedCustomer>(q => q
+                .Join<AliasedCustomerAddress>()
+                .Join<AliasedCustomerAddress, Country>((ca, c) => ca.Country == c.CountryName));
+
+            Assert.That(dbCustomers.Count, Is.EqualTo(2));
+
+            //Left Join
+            dbCustomers = db.Select<AliasedCustomer>(q => q
+                .Join<AliasedCustomerAddress>()
+                .LeftJoin<AliasedCustomerAddress, Country>((ca, c) => ca.Country == c.CountryName));
+
+            Assert.That(dbCustomers.Count, Is.EqualTo(3));
+
+            //Warning: Right and Full Joins are not implemented by Sqlite3. Avoid if possible.
+            var dbCountries = db.Select<Country>(q => q
+                .LeftJoin<AliasedCustomerAddress>((c, ca) => ca.Country == c.CountryName)
+                .LeftJoin<AliasedCustomerAddress, AliasedCustomer>());
+
+            Assert.That(dbCountries.Count, Is.EqualTo(4));
+
+            var dbAddresses = db.Select<AliasedCustomerAddress>(q => q
+                .LeftJoin<Country>((ca, c) => ca.Country == c.CountryName)
+                .LeftJoin<AliasedCustomerAddress, AliasedCustomer>());
+
+            Assert.That(dbAddresses.Count, Is.EqualTo(3));
+        }
     }
 }

tests/ServiceStack.OrmLite.Tests/LoadReferencesTests.cs

@@ -78,7 +78,7 @@ public class AliasedCustomerAddress
         [AutoIncrement]
         public int Id { get; set; }
         [Alias("Q_CustomerId")]
-        public int AliasedCustomerId { get; set; }
+        public int AliasedCustId { get; set; }
         public string AddressLine1 { get; set; }
         public string AddressLine2 { get; set; }
         public string City { get; set; }
@@ -239,10 +239,10 @@ public void Can_Save_and_Load_Aliased_References()
             db.Save(customer);
 
             Assert.That(customer.Id, Is.GreaterThan(0));
-            Assert.That(customer.PrimaryAddress.AliasedCustomerId, Is.EqualTo(0));
+            Assert.That(customer.PrimaryAddress.AliasedCustId, Is.EqualTo(0));
 
             db.SaveReferences(customer, customer.PrimaryAddress);
-            Assert.That(customer.PrimaryAddress.AliasedCustomerId, Is.EqualTo(customer.Id));
+            Assert.That(customer.PrimaryAddress.AliasedCustId, Is.EqualTo(customer.Id));
 
             var dbCustomer = db.LoadSingleById<AliasedCustomer>(customer.Id);