Merge pull request #308 from angelcolmenares/master

fixed some bugs in firebirdsql

Author: angelcolmenares

src/ServiceStack.OrmLite.Firebird/FirebirdOrmLiteDialectProvider.cs

@@ -233,8 +233,11 @@ public override string ToInsertRowStatement(IDbCommand dbCommand, object objWith
 		}
 
 
-		public override string ToUpdateRowStatement(object objWithProperties, ICollection<string> updateFields)
+		public override string ToUpdateRowStatement(object objWithProperties, ICollection<string> updateFields=null)
 		{
+			if (updateFields == null) 
+				updateFields = new List<string>();
+				
 			var sqlFilter = new StringBuilder();
 			var sql = new StringBuilder();
 			var tableType = objWithProperties.GetType();

tests/ServiceStack.OrmLite.FirebirdTests/Expressions/OrmLiteCountTests.cs

@@ -65,15 +65,13 @@ public void CanDoCountWithInterfaceAndPredicate()
 
         long Count<T>(IDbConnection db) where T : IHasId<int>, new()
         {
-            T request = new T();
-            return db.GetScalar<T, long>(e => Sql.Count(request.Id));
+            return db.GetScalar<T, long>(e => Sql.Count(e.Id));
         }
 
 
         long CountByColumn<T>(IDbConnection db) where T : IHasCountColumn, new()
         {
-            T request = new T();
-            return db.GetScalar<T, long?>(e => Sql.Count(request.CountColumn)).Value;
+            return db.GetScalar<T, long?>(e => Sql.Count(e.CountColumn)).Value;
         }
 
 
@@ -108,4 +106,4 @@ public CountTestTable() { }
         public int? CountColumn { get; set; }
         #endregion
     }
-}
+}

tests/ServiceStack.OrmLite.FirebirdTests/OrmLiteTestBase.cs

@@ -15,8 +15,8 @@ public class OrmLiteTestBase
 
 		protected string GetFileConnectionString()
 		{
-			// add ormlite-tests.fdb = D:\\ormlite-tests.fdb to your firebird  alias.conf 
-			return ConfigurationManager.ConnectionStrings["testDb"].ConnectionString;
+			// add ormlite-tests.fdb = {PATH TO FDB FILE} D:\\ormlite-tests.fdb to your firebird  alias.conf 
+			return "User=SYSDBA;Password=masterkey;Database=ormlite-tests.fdb;DataSource=localhost;Dialect=3;charset=ISO8859_1;MinPoolSize=0;MaxPoolSize=100;";
 		}
 
 		protected void CreateNewDatabase()
@@ -38,4 +38,4 @@ public void Log(string text)
 			Console.WriteLine(text);
 		}
 	}
-}
+}