User defined inlet velocity profile fails

[ktbolt]

Description

A user-defied inlet velocity profile can be specified using

   <Add_BC name="left" >
     <Type> Dirichlet </Type>
     <Time_dependence> Steady </Time_dependence>
     <Profile> User_defined </Profile>
     <Spatial_profile_file_path> vel_profile.txt </Spatial_profile_file_path>
     <Value> -100 </Value>
   </Add_BC>

However, the solver fails with

[svMultiPhysics] ERROR: The svMultiPhysics program has failed due to unhandled exception.
FSILS: A zero matrix norm has been computed. This is probably caused by ill-posed boundary conditions.

Reproduction

Run a CFD simulation with a user-defied inlet velocity profile

Expected behavior

A CFD simulation with a user-defied inlet velocity profile should work.

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct and Contributing Guidelines

[ktbolt]

A user was trying to use a user-defied inlet velocity profile for a 2D CFD simulation but it was failing. To test I created a spatial profile file based on a parabolic profile and saw that the file was read in correctly and the lBc.gx array storing the velocity profile was being set correctly.

[ktbolt]

Looking at the read_files::read_spatial_values function I see the comment

// [TODO:DaveP] this is not tested.

and indeed there are no tests for this.

[ktbolt]

The problem was that lBc.gx was being resized in baf_ini_ns::bc_ini without checking if it had already been allocated.

The results for a spatial profile file based on a parabolic profile now match the Parabolic profile results.

[ktbolt]

I will add a unit test for

1. Reading input velocity profile text file

2. Correctly setting lBc.gx