Skip to content

Commit ce9f469

Browse files
author
Raphael Gachuhi
committed
A2 image_hotspot bug fix
1 parent 6db7ed1 commit ce9f469

2 files changed

Lines changed: 0 additions & 11 deletions

File tree

src/main/java/edu/cmu/oli/assessment/evaluators/MatcherByType.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
import edu.cmu.oli.assessment.InputFormatException;
3131
import edu.cmu.oli.assessment.InteractionStyle;
3232
import edu.cmu.oli.assessment.PatternFormatException;
33-
import org.slf4j.Logger;
34-
import org.slf4j.LoggerFactory;
3533

3634
import java.math.BigDecimal;
3735
import java.util.ArrayList;
@@ -44,8 +42,6 @@
4442
* @author Raphael Gachuhi
4543
*/
4644
public class MatcherByType {
47-
static final Logger log = LoggerFactory.getLogger(MatcherByType.class);
48-
4945
JsonObject interaction;
5046

5147
public MatcherByType(JsonObject interaction) {
@@ -77,7 +73,6 @@ public ResponseMatcher parseMatchPattern(String pattern)
7773
case ORDERING:
7874
return ordering(pattern);
7975
case NUMERIC:
80-
log.info("numeric");
8176
return numeric(pattern);
8277
case IMAGE_HOTSPOT:
8378
return imageHotSpot(pattern);
@@ -144,7 +139,6 @@ private ResponseMatcher<? super BigDecimal> numeric(String pattern)
144139
// Precision
145140
int p = pattern.indexOf("#");
146141
if (p >= 0) {
147-
log.info("precision 1");
148142
int precision;
149143
try {
150144
precision = Integer.parseInt(pattern.substring(p + 1));

src/main/java/edu/cmu/oli/assessment/evaluators/PrecisionMatcher.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,9 @@
2424

2525
package edu.cmu.oli.assessment.evaluators;
2626

27-
import org.slf4j.Logger;
28-
import org.slf4j.LoggerFactory;
29-
3027
import java.math.BigDecimal;
3128

3229
public class PrecisionMatcher implements ResponseMatcher<BigDecimal> {
33-
static final Logger log = LoggerFactory.getLogger(PrecisionMatcher.class);
3430
private int precision;
3531

3632
public PrecisionMatcher(int precision) {
@@ -56,7 +52,6 @@ public void setPrecision(int precision) {
5652
}
5753

5854
public boolean matches(BigDecimal response) {
59-
log.info("value= "+ response + "match precision:= "+response.precision() +" vs " + precision + " vs scale= " + response.scale());
6055
if (response == null) return false;
6156
return (precision == response.precision());
6257
}

0 commit comments

Comments
 (0)