remove null checks

SimonCropp · SimonCropp · commit b05d9fda2dd3 · 2021-06-29T10:03:36.000+10:00
diff --git a/src/GraphQL.EntityFramework/EfDocumentExecuter.cs b/src/GraphQL.EntityFramework/EfDocumentExecuter.cs
@@ -8,7 +8,6 @@ public class EfDocumentExecuter :
     {
         protected override IExecutionStrategy SelectExecutionStrategy(ExecutionContext context)
         {
-            Guard.AgainstNull(nameof(context), context);
             if (context.Operation.OperationType == OperationType.Query)
             {
                 return new SerialExecutionStrategy();
diff --git a/src/GraphQL.EntityFramework/EfGraphQLConventions.cs b/src/GraphQL.EntityFramework/EfGraphQLConventions.cs
@@ -31,8 +31,6 @@ public static void RegisterInContainer<TDbContext>(
 
             where TDbContext : DbContext
         {
-            Guard.AgainstNull(nameof(services), services);
-
             RegisterScalarsAndArgs(services);
             services.AddHttpContextAccessor();
             services.AddTransient<HttpContextCapture>();
@@ -90,7 +88,6 @@ static void RegisterScalarsAndArgs(IServiceCollection services)
 
         public static void RegisterConnectionTypesInContainer(IServiceCollection services)
         {
-            Guard.AgainstNull(nameof(services), services);
             services.AddTransient(typeof(ConnectionType<>));
             services.AddTransient(typeof(EdgeType<>));
             services.AddSingleton<PageInfoType>();
diff --git a/src/GraphQL.EntityFramework/Filters/Filters.cs b/src/GraphQL.EntityFramework/Filters/Filters.cs
@@ -20,7 +20,6 @@ public delegate Task<bool> AsyncFilter<in TEntity>(object userContext, TEntity i
         public void Add<TEntity>(Filter<TEntity> filter)
             where TEntity : class
         {
-            Guard.AgainstNull(nameof(filter), filter);
             funcs[typeof(TEntity)] =
                 (context, item) =>
                 {
@@ -38,7 +37,6 @@ public void Add<TEntity>(Filter<TEntity> filter)
         public void Add<TEntity>(AsyncFilter<TEntity> filter)
             where TEntity : class
         {
-            Guard.AgainstNull(nameof(filter), filter);
             funcs[typeof(TEntity)] =
                 async (context, item) =>
                 {
diff --git a/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService.cs b/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService.cs
@@ -22,8 +22,6 @@ public EfGraphQLService(
             ResolveFilters? resolveFilters = null,
             bool disableTracking = false)
         {
-            Guard.AgainstNull(nameof(model), model);
-            Guard.AgainstNull(nameof(resolveDbContext), resolveDbContext);
             this.resolveFilters = resolveFilters;
             this.disableTracking = disableTracking;
 
@@ -72,7 +70,6 @@ ResolveEfFieldContext<TDbContext, TSource> BuildContext<TSource>(
 
         public TDbContext ResolveDbContext(IResolveFieldContext context)
         {
-            Guard.AgainstNull(nameof(context), context);
             return resolveDbContext(context.UserContext);
         }
 
diff --git a/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_Navigation.cs b/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_Navigation.cs
@@ -18,7 +18,6 @@ public FieldType AddNavigationField<TSource, TReturn>(
             string? description = null)
             where TReturn : class
         {
-            Guard.AgainstNull(nameof(graph), graph);
             Guard.AgainstNullWhiteSpace(nameof(name), name);
 
             graphType ??= GraphTypeFinder.FindGraphType<TReturn>();
diff --git a/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_NavigationConnection.cs b/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_NavigationConnection.cs
@@ -25,8 +25,6 @@ public void AddNavigationConnectionField<TSource, TReturn>(
             string? description = null)
             where TReturn : class
         {
-            Guard.AgainstNull(nameof(graph), graph);
-
             Guard.AgainstNullWhiteSpace(nameof(name), name);
             Guard.AgainstNegative(nameof(pageSize), pageSize);
 
diff --git a/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_NavigationList.cs b/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_NavigationList.cs
@@ -19,7 +19,6 @@ public FieldType AddNavigationListField<TSource, TReturn>(
             string? description = null)
             where TReturn : class
         {
-            Guard.AgainstNull(nameof(graph), graph);
             Guard.AgainstNullWhiteSpace(nameof(name), name);
 
             var hasId = keyNames.ContainsKey(typeof(TReturn));
diff --git a/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_Queryable.cs b/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_Queryable.cs
@@ -19,7 +19,6 @@ public FieldType AddQueryField<TReturn>(
             string? description = null)
             where TReturn : class
         {
-            Guard.AgainstNull(nameof(graph), graph);
             var field = BuildQueryField(graphType, name, resolve, arguments, description);
             return graph.AddField(field);
         }
@@ -33,7 +32,6 @@ public FieldType AddQueryField<TSource, TReturn>(
             string? description = null)
             where TReturn : class
         {
-            Guard.AgainstNull(nameof(graph), graph);
             var field = BuildQueryField(itemGraphType, name, resolve, arguments, description);
             return graph.AddField(field);
         }
diff --git a/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_QueryableConnection.cs b/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_QueryableConnection.cs
@@ -20,7 +20,6 @@ public void AddQueryConnectionField<TReturn>(
             string? description = null)
             where TReturn : class
         {
-            Guard.AgainstNull(nameof(graph), graph);
             BuildQueryConnectionField(graph, name, resolve, arguments, pageSize, itemGraphType, description);
         }
 
@@ -34,7 +33,6 @@ public void AddQueryConnectionField<TSource, TReturn>(
             string? description = null)
             where TReturn : class
         {
-            Guard.AgainstNull(nameof(graph), graph);
             BuildQueryConnectionField(graph, name, resolve, arguments, pageSize, itemGraphType, description);
         }
 
diff --git a/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_Single.cs b/src/GraphQL.EntityFramework/GraphApi/EfGraphQLService_Single.cs
@@ -22,7 +22,6 @@ public FieldType AddSingleField<TReturn>(
             string? description = null)
             where TReturn : class
         {
-            Guard.AgainstNull(nameof(graph), graph);
             var field = BuildSingleField(name, resolve, mutate, arguments, graphType, nullable, description);
             return graph.AddField(field);
         }
@@ -38,7 +37,6 @@ public FieldType AddSingleField<TReturn>(
             string? description = null)
             where TReturn : class
         {
-            Guard.AgainstNull(nameof(graph), graph);
             var field = BuildSingleField(name, resolve, mutate, arguments, graphType, nullable, description);
             return graph.AddField(field);
         }
@@ -54,7 +52,6 @@ public FieldType AddSingleField<TSource, TReturn>(
             string? description = null)
             where TReturn : class
         {
-            Guard.AgainstNull(nameof(graph), graph);
             var field = BuildSingleField(name, resolve, mutate, arguments, graphType, nullable, description);
             return graph.AddField(field);
         }
@@ -70,7 +67,6 @@ FieldType BuildSingleField<TSource, TReturn>(
             where TReturn : class
         {
             Guard.AgainstNullWhiteSpace(nameof(name), name);
-            Guard.AgainstNull(nameof(resolve), resolve);
 
             graphType ??= GraphTypeFinder.FindGraphType<TReturn>(nullable);
 
diff --git a/src/GraphQL.EntityFramework/GraphApi/EfInterfaceGraphType.cs b/src/GraphQL.EntityFramework/GraphApi/EfInterfaceGraphType.cs
@@ -13,7 +13,6 @@ public class EfInterfaceGraphType<TDbContext, TSource> :
 
         public EfInterfaceGraphType(IEfGraphQLService<TDbContext> graphQlService)
         {
-            Guard.AgainstNull(nameof(graphQlService), graphQlService);
             GraphQlService = graphQlService;
         }
 
@@ -73,13 +72,11 @@ public FieldType AddQueryField<TReturn>(
 
         public TDbContext ResolveDbContext(IResolveFieldContext<TSource> context)
         {
-            Guard.AgainstNull(nameof(context), context);
             return GraphQlService.ResolveDbContext(context);
         }
 
         public TDbContext ResolveDbContext(IResolveFieldContext context)
         {
-            Guard.AgainstNull(nameof(context), context);
             return GraphQlService.ResolveDbContext(context);
         }
     }
diff --git a/src/GraphQL.EntityFramework/GraphApi/EfObjectGraphType.cs b/src/GraphQL.EntityFramework/GraphApi/EfObjectGraphType.cs
@@ -15,7 +15,6 @@ public class EfObjectGraphType<TDbContext, TSource> :
 
         public EfObjectGraphType(IEfGraphQLService<TDbContext> graphQlService)
         {
-            Guard.AgainstNull(nameof(graphQlService), graphQlService);
             GraphQlService = graphQlService;
         }
 
@@ -93,13 +92,11 @@ public FieldType AddQueryField<TReturn>(
 
         public TDbContext ResolveDbContext(IResolveFieldContext<TSource> context)
         {
-            Guard.AgainstNull(nameof(context), context);
             return GraphQlService.ResolveDbContext(context);
         }
 
         public TDbContext ResolveDbContext(IResolveFieldContext context)
         {
-            Guard.AgainstNull(nameof(context), context);
             return GraphQlService.ResolveDbContext(context);
         }
 
diff --git a/src/GraphQL.EntityFramework/GraphApi/QueryGraphType.cs b/src/GraphQL.EntityFramework/GraphApi/QueryGraphType.cs
@@ -13,21 +13,18 @@ public class QueryGraphType<TDbContext> :
     {
         public QueryGraphType(IEfGraphQLService<TDbContext> graphQlService)
         {
-            Guard.AgainstNull(nameof(graphQlService), graphQlService);
             GraphQlService = graphQlService;
         }
 
         public IEfGraphQLService<TDbContext> GraphQlService { get; }
 
         public TDbContext ResolveDbContext<TSource>(IResolveFieldContext<TSource> context)
         {
-            Guard.AgainstNull(nameof(context), context);
             return GraphQlService.ResolveDbContext(context);
         }
 
         public TDbContext ResolveDbContext(IResolveFieldContext context)
         {
-            Guard.AgainstNull(nameof(context), context);
             return GraphQlService.ResolveDbContext(context);
         }
 
diff --git a/src/GraphQL.EntityFramework/GraphQlExtensions.cs b/src/GraphQL.EntityFramework/GraphQlExtensions.cs
@@ -24,8 +24,6 @@ public static async Task<ExecutionResult> ExecuteWithErrorCheck(
             this IDocumentExecuter executer,
             ExecutionOptions options)
         {
-            Guard.AgainstNull(nameof(executer), executer);
-            Guard.AgainstNull(nameof(options), options);
             var executionResult = await executer.ExecuteAsync(options);
 
             var errors = executionResult.Errors;
diff --git a/src/GraphQL.EntityFramework/Guard.cs b/src/GraphQL.EntityFramework/Guard.cs
@@ -2,14 +2,6 @@
 
 static class Guard
 {
-    public static void AgainstNull(string argumentName, object value)
-    {
-        if (value == null)
-        {
-            throw new ArgumentNullException(argumentName);
-        }
-    }
-
     public static void AgainstNullWhiteSpace(string argumentName, string value)
     {
         if (string.IsNullOrWhiteSpace(value))
diff --git a/src/GraphQL.EntityFramework/Testing/ClientQueryExecutor.cs b/src/GraphQL.EntityFramework/Testing/ClientQueryExecutor.cs
@@ -19,7 +19,6 @@ public ClientQueryExecutor(Func<object, string> toJson, string uri = "graphql")
 
         public Task<HttpResponseMessage> ExecutePost(HttpClient client, string query, object? variables = null, Action<HttpHeaders>? headerAction = null)
         {
-            Guard.AgainstNull(nameof(client), client);
             Guard.AgainstNullWhiteSpace(nameof(query), query);
             query = CompressQuery(query);
             var body = new
@@ -37,7 +36,6 @@ public Task<HttpResponseMessage> ExecutePost(HttpClient client, string query, ob
 
         public Task<HttpResponseMessage> ExecuteGet(HttpClient client, string query, object? variables = null, Action<HttpHeaders>? headerAction = null)
         {
-            Guard.AgainstNull(nameof(client), client);
             Guard.AgainstNullWhiteSpace(nameof(query), query);
             var compressed = CompressQuery(query);
             var variablesString = ToJson(variables);
diff --git a/src/GraphQL.EntityFramework/Where/ArgumentProcessor_List.cs b/src/GraphQL.EntityFramework/Where/ArgumentProcessor_List.cs
@@ -8,8 +8,6 @@ public static partial class ArgumentProcessor
     {
         public static IEnumerable<TItem> ApplyGraphQlArguments<TItem, TSource>(this IEnumerable<TItem> items, bool hasId, IResolveFieldContext<TSource> context)
         {
-            Guard.AgainstNull(nameof(items), items);
-            Guard.AgainstNull(nameof(context), context);
             return ApplyToAll(items, hasId, (type, x) => context.GetArgument(type, x));
         }
 
diff --git a/src/GraphQL.EntityFramework/Where/ArgumentProcessor_Queryable.cs b/src/GraphQL.EntityFramework/Where/ArgumentProcessor_Queryable.cs
@@ -13,8 +13,6 @@ public static IQueryable<TItem> ApplyGraphQlArguments<TItem>(
             bool applyOrder)
             where TItem : class
         {
-            Guard.AgainstNull(nameof(queryable), queryable);
-            Guard.AgainstNull(nameof(context), context);
             object? GetArguments(Type type, string x) => context.GetArgument(type, x);
 
             if (keyNames != null)

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ public class EfDocumentExecuter :`
`8`	`8`	`{`
`9`	`9`	`protected override IExecutionStrategy SelectExecutionStrategy(ExecutionContext context)`
`10`	`10`	`{`
`11`		`- Guard.AgainstNull(nameof(context), context);`
`12`	`11`	`if (context.Operation.OperationType == OperationType.Query)`
`13`	`12`	`{`
`14`	`13`	`return new SerialExecutionStrategy();`
Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,6 @@ public static void RegisterInContainer<TDbContext>(`
`31`	`31`
`32`	`32`	`where TDbContext : DbContext`
`33`	`33`	`{`
`34`		`- Guard.AgainstNull(nameof(services), services);`
`35`		`-`
`36`	`34`	`RegisterScalarsAndArgs(services);`
`37`	`35`	`services.AddHttpContextAccessor();`
`38`	`36`	`services.AddTransient<HttpContextCapture>();`
`@@ -90,7 +88,6 @@ static void RegisterScalarsAndArgs(IServiceCollection services)`
`90`	`88`
`91`	`89`	`public static void RegisterConnectionTypesInContainer(IServiceCollection services)`
`92`	`90`	`{`
`93`		`- Guard.AgainstNull(nameof(services), services);`
`94`	`91`	`services.AddTransient(typeof(ConnectionType<>));`
`95`	`92`	`services.AddTransient(typeof(EdgeType<>));`
`96`	`93`	`services.AddSingleton<PageInfoType>();`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ public delegate Task<bool> AsyncFilter<in TEntity>(object userContext, TEntity i`
`20`	`20`	`public void Add<TEntity>(Filter<TEntity> filter)`
`21`	`21`	`where TEntity : class`
`22`	`22`	`{`
`23`		`- Guard.AgainstNull(nameof(filter), filter);`
`24`	`23`	`funcs[typeof(TEntity)] =`
`25`	`24`	`(context, item) =>`
`26`	`25`	`{`
`@@ -38,7 +37,6 @@ public void Add<TEntity>(Filter<TEntity> filter)`
`38`	`37`	`public void Add<TEntity>(AsyncFilter<TEntity> filter)`
`39`	`38`	`where TEntity : class`
`40`	`39`	`{`
`41`		`- Guard.AgainstNull(nameof(filter), filter);`
`42`	`40`	`funcs[typeof(TEntity)] =`
`43`	`41`	`async (context, item) =>`
`44`	`42`	`{`
Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,6 @@ public EfGraphQLService(`
`22`	`22`	`ResolveFilters? resolveFilters = null,`
`23`	`23`	`bool disableTracking = false)`
`24`	`24`	`{`
`25`		`- Guard.AgainstNull(nameof(model), model);`
`26`		`- Guard.AgainstNull(nameof(resolveDbContext), resolveDbContext);`
`27`	`25`	`this.resolveFilters = resolveFilters;`
`28`	`26`	`this.disableTracking = disableTracking;`
`29`	`27`
`@@ -72,7 +70,6 @@ ResolveEfFieldContext<TDbContext, TSource> BuildContext<TSource>(`
`72`	`70`
`73`	`71`	`public TDbContext ResolveDbContext(IResolveFieldContext context)`
`74`	`72`	`{`
`75`		`- Guard.AgainstNull(nameof(context), context);`
`76`	`73`	`return resolveDbContext(context.UserContext);`
`77`	`74`	`}`
`78`	`75`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ public FieldType AddNavigationField<TSource, TReturn>(`
`18`	`18`	`string? description = null)`
`19`	`19`	`where TReturn : class`
`20`	`20`	`{`
`21`		`- Guard.AgainstNull(nameof(graph), graph);`
`22`	`21`	`Guard.AgainstNullWhiteSpace(nameof(name), name);`
`23`	`22`
`24`	`23`	`graphType ??= GraphTypeFinder.FindGraphType<TReturn>();`
Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,6 @@ public void AddNavigationConnectionField<TSource, TReturn>(`
`25`	`25`	`string? description = null)`
`26`	`26`	`where TReturn : class`
`27`	`27`	`{`
`28`		`- Guard.AgainstNull(nameof(graph), graph);`
`29`		`-`
`30`	`28`	`Guard.AgainstNullWhiteSpace(nameof(name), name);`
`31`	`29`	`Guard.AgainstNegative(nameof(pageSize), pageSize);`
`32`	`30`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ public FieldType AddNavigationListField<TSource, TReturn>(`
`19`	`19`	`string? description = null)`
`20`	`20`	`where TReturn : class`
`21`	`21`	`{`
`22`		`- Guard.AgainstNull(nameof(graph), graph);`
`23`	`22`	`Guard.AgainstNullWhiteSpace(nameof(name), name);`
`24`	`23`
`25`	`24`	`var hasId = keyNames.ContainsKey(typeof(TReturn));`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ public FieldType AddQueryField<TReturn>(`
`19`	`19`	`string? description = null)`
`20`	`20`	`where TReturn : class`
`21`	`21`	`{`
`22`		`- Guard.AgainstNull(nameof(graph), graph);`
`23`	`22`	`var field = BuildQueryField(graphType, name, resolve, arguments, description);`
`24`	`23`	`return graph.AddField(field);`
`25`	`24`	`}`
`@@ -33,7 +32,6 @@ public FieldType AddQueryField<TSource, TReturn>(`
`33`	`32`	`string? description = null)`
`34`	`33`	`where TReturn : class`
`35`	`34`	`{`
`36`		`- Guard.AgainstNull(nameof(graph), graph);`
`37`	`35`	`var field = BuildQueryField(itemGraphType, name, resolve, arguments, description);`
`38`	`36`	`return graph.AddField(field);`
`39`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ public void AddQueryConnectionField<TReturn>(`
`20`	`20`	`string? description = null)`
`21`	`21`	`where TReturn : class`
`22`	`22`	`{`
`23`		`- Guard.AgainstNull(nameof(graph), graph);`
`24`	`23`	`BuildQueryConnectionField(graph, name, resolve, arguments, pageSize, itemGraphType, description);`
`25`	`24`	`}`
`26`	`25`
`@@ -34,7 +33,6 @@ public void AddQueryConnectionField<TSource, TReturn>(`
`34`	`33`	`string? description = null)`
`35`	`34`	`where TReturn : class`
`36`	`35`	`{`
`37`		`- Guard.AgainstNull(nameof(graph), graph);`
`38`	`36`	`BuildQueryConnectionField(graph, name, resolve, arguments, pageSize, itemGraphType, description);`
`39`	`37`	`}`
`40`	`38`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@ public FieldType AddSingleField<TReturn>(`
`22`	`22`	`string? description = null)`
`23`	`23`	`where TReturn : class`
`24`	`24`	`{`
`25`		`- Guard.AgainstNull(nameof(graph), graph);`
`26`	`25`	`var field = BuildSingleField(name, resolve, mutate, arguments, graphType, nullable, description);`
`27`	`26`	`return graph.AddField(field);`
`28`	`27`	`}`
`@@ -38,7 +37,6 @@ public FieldType AddSingleField<TReturn>(`
`38`	`37`	`string? description = null)`
`39`	`38`	`where TReturn : class`
`40`	`39`	`{`
`41`		`- Guard.AgainstNull(nameof(graph), graph);`
`42`	`40`	`var field = BuildSingleField(name, resolve, mutate, arguments, graphType, nullable, description);`
`43`	`41`	`return graph.AddField(field);`
`44`	`42`	`}`
`@@ -54,7 +52,6 @@ public FieldType AddSingleField<TSource, TReturn>(`
`54`	`52`	`string? description = null)`
`55`	`53`	`where TReturn : class`
`56`	`54`	`{`
`57`		`- Guard.AgainstNull(nameof(graph), graph);`
`58`	`55`	`var field = BuildSingleField(name, resolve, mutate, arguments, graphType, nullable, description);`
`59`	`56`	`return graph.AddField(field);`
`60`	`57`	`}`
`@@ -70,7 +67,6 @@ FieldType BuildSingleField<TSource, TReturn>(`
`70`	`67`	`where TReturn : class`
`71`	`68`	`{`
`72`	`69`	`Guard.AgainstNullWhiteSpace(nameof(name), name);`
`73`		`- Guard.AgainstNull(nameof(resolve), resolve);`
`74`	`70`
`75`	`71`	`graphType ??= GraphTypeFinder.FindGraphType<TReturn>(nullable);`
`76`	`72`