Skip to content

Commit a69e106

Browse files
author
Simon Schubert
committed
Fix imports
1 parent 4c86e07 commit a69e106

9 files changed

Lines changed: 13 additions & 20 deletions

File tree

android/src/main/java/com/inspiredandroid/linuxcommandbibliotheca/MainActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ fun LinuxApp() {
110110
TextFieldValue(text = "", selection = TextRange(0)),
111111
)
112112
}
113-
val showSearch = remember { mutableStateof(false) }
113+
val showSearch = remember { mutableStateOf(false) }
114114
val onNavigate: (String) -> Unit = remember(navController) { { route -> navController.navigate(route) } }
115115

116116
Scaffold(

android/src/main/java/com/inspiredandroid/linuxcommandbibliotheca/ui/screens/basicgroups/BasicGroupsScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ fun BasicGroupsScreen(
6060
) { basicGroup ->
6161
BasicGroupColumn(
6262
basicGroup = basicGroup,
63-
isExpanded = !uiState.collapsedMap.getOrDefault(basicGroup.id, false),
63+
isExpanded = !uiState.collapsedMap.getOrDefault(basicGroup.id, true),
6464
onToggleCollapse = { viewModel.toggleCollapse(basicGroup.id) },
6565
onNavigate = onNavigate,
6666
)

android/src/main/java/com/inspiredandroid/linuxcommandbibliotheca/ui/screens/basicgroups/BasicGroupsUiState.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ import kotlinx.collections.immutable.persistentMapOf
88

99
data class BasicGroupsUiState(
1010
val basicGroups: ImmutableList<BasicGroup> = persistentListOf(),
11-
val collapsedMap: ImmutableMap<Long, Boolean> = persistentMapOf()
11+
val collapsedMap: ImmutableMap<Long, Boolean> = persistentMapOf(),
1212
)

android/src/main/java/com/inspiredandroid/linuxcommandbibliotheca/ui/screens/basicgroups/BasicGroupsViewModel.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,12 @@ class BasicGroupsViewModel(categoryId: Long) : ViewModel() {
3333
_uiState.value = BasicGroupsUiState(basicGroups = groups)
3434
}
3535

36-
fun isGroupCollapsed(id: Long): Boolean =
37-
_uiState.value.collapsedMap.getOrDefault(id, false)
36+
fun isGroupCollapsed(id: Long): Boolean = _uiState.value.collapsedMap.getOrDefault(id, true)
3837

3938
fun toggleCollapse(id: Long) {
4039
_uiState.update { currentState ->
4140
val newMap = currentState.collapsedMap.toMutableMap()
42-
newMap[id] = !currentState.collapsedMap.getOrDefault(id, false)
41+
newMap[id] = !currentState.collapsedMap.getOrDefault(id, true)
4342
currentState.copy(collapsedMap = newMap.toPersistentMap())
4443
}
4544
}

android/src/main/java/com/inspiredandroid/linuxcommandbibliotheca/ui/screens/commandlist/CommandListScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import androidx.compose.material.ListItem
1515
import androidx.compose.runtime.Composable
1616
import androidx.compose.runtime.collectAsState
1717
import androidx.compose.runtime.getValue
18+
import androidx.compose.runtime.remember
1819
import androidx.compose.ui.Modifier
1920
import androidx.compose.ui.res.painterResource
2021
import androidx.compose.ui.res.stringResource
@@ -93,7 +94,7 @@ fun CommandListItem(
9394
modifier = Modifier.clickable(
9495
onClick = remember(command.id, command.name, onNavigate) {
9596
{ onNavigate("command?commandId=${command.id}&commandName=${command.name}") }
96-
}
97+
},
9798
),
9899
)
99100
}

android/src/main/java/com/inspiredandroid/linuxcommandbibliotheca/ui/screens/search/SearchUiState.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ import kotlinx.collections.immutable.persistentMapOf
1010
data class SearchUiState(
1111
val filteredCommands: ImmutableList<Command> = persistentListOf(),
1212
val filteredBasicGroups: ImmutableList<BasicGroup> = persistentListOf(),
13-
val collapsedMap: ImmutableMap<Long, Boolean> = persistentMapOf()
13+
val collapsedMap: ImmutableMap<Long, Boolean> = persistentMapOf(),
1414
)

android/src/main/java/com/inspiredandroid/linuxcommandbibliotheca/ui/screens/search/SearchViewModel.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import androidx.lifecycle.ViewModel
44
import androidx.lifecycle.viewModelScope
55
import com.linuxcommandlibrary.shared.databaseHelper
66
import com.linuxcommandlibrary.shared.sortedSearch
7+
import kotlinx.collections.immutable.persistentListOf
78
import kotlinx.collections.immutable.toImmutableList
89
import kotlinx.collections.immutable.toPersistentMap
910
import kotlinx.coroutines.Dispatchers
@@ -20,8 +21,7 @@ class SearchViewModel : ViewModel() {
2021
private val _uiState = MutableStateFlow(SearchUiState())
2122
val uiState = _uiState.asStateFlow()
2223

23-
fun isGroupCollapsed(id: Long): Boolean =
24-
_uiState.value.collapsedMap.getOrDefault(id, false)
24+
fun isGroupCollapsed(id: Long): Boolean = _uiState.value.collapsedMap.getOrDefault(id, false)
2525

2626
fun toggleCollapse(id: Long) {
2727
_uiState.update { currentState ->
@@ -38,7 +38,7 @@ class SearchViewModel : ViewModel() {
3838
_uiState.update {
3939
it.copy(
4040
filteredCommands = persistentListOf(),
41-
filteredBasicGroups = persistentListOf()
41+
filteredBasicGroups = persistentListOf(),
4242
)
4343
}
4444
return
@@ -55,7 +55,7 @@ class SearchViewModel : ViewModel() {
5555
_uiState.update { currentState ->
5656
currentState.copy(
5757
filteredCommands = commands.toImmutableList(),
58-
filteredBasicGroups = basicGroups.toImmutableList()
58+
filteredBasicGroups = basicGroups.toImmutableList(),
5959
)
6060
}
6161
} catch (ignore: CancellationException) {

android/src/test/java/com/inspiredandroid/linuxcommandbibliotheca/ui/screens/basicgroups/BasicGroupsViewModelTest.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,8 @@ import app.cash.turbine.test
44
import com.linuxcommandlibrary.shared.databaseHelper
55
import databases.BasicGroup
66
import io.mockk.every
7-
import io.mockk.mockk
87
import io.mockk.mockkObject
98
import io.mockk.unmockkObject
10-
import kotlinx.collections.immutable.persistentListOf
119
import kotlinx.coroutines.Dispatchers
1210
import kotlinx.coroutines.ExperimentalCoroutinesApi
1311
import kotlinx.coroutines.test.StandardTestDispatcher
@@ -43,7 +41,7 @@ class BasicGroupsViewModelTest {
4341
val categoryId = 1L
4442
val mockGroups = listOf(
4543
BasicGroup(1L, "Group 1", categoryId, 0, "icon1"),
46-
BasicGroup(2L, "Group 2", categoryId, 0, "icon2")
44+
BasicGroup(2L, "Group 2", categoryId, 0, "icon2"),
4745
)
4846
every { databaseHelper.getBasicGroupsByQuery(categoryId) } returns mockGroups
4947

android/src/test/java/com/inspiredandroid/linuxcommandbibliotheca/ui/screens/search/SearchViewModelTest.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,8 @@ import com.linuxcommandlibrary.shared.databaseHelper
55
import databases.BasicGroup
66
import databases.Command
77
import io.mockk.coEvery
8-
import io.mockk.coVerify
9-
import io.mockk.every
10-
import io.mockk.mockk
118
import io.mockk.mockkObject
129
import io.mockk.unmockkObject
13-
import kotlinx.collections.immutable.persistentListOf
1410
import kotlinx.coroutines.Dispatchers
1511
import kotlinx.coroutines.ExperimentalCoroutinesApi
1612
import kotlinx.coroutines.delay
@@ -104,7 +100,6 @@ class SearchViewModelTest {
104100
assertTrue(latestState.filteredBasicGroups.isEmpty())
105101
}
106102

107-
108103
@Test
109104
fun `search cancels previous search`() = runTest {
110105
val searchText1 = "search1"

0 commit comments

Comments
 (0)