Skip to content

Commit d4444bc

Browse files
committed
Simplify base app layout composeables
1 parent dce3f30 commit d4444bc

2 files changed

Lines changed: 13 additions & 51 deletions

File tree

  • android/src/main/java/com/inspiredandroid/linuxcommandbibliotheca
  • composeApp/src/commonMain/kotlin/com/linuxcommandlibrary/app

android/src/main/java/com/inspiredandroid/linuxcommandbibliotheca/MainActivity.kt

Lines changed: 1 addition & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,7 @@ import androidx.activity.SystemBarStyle
55
import androidx.activity.compose.setContent
66
import androidx.activity.enableEdgeToEdge
77
import androidx.appcompat.app.AppCompatActivity
8-
import androidx.compose.foundation.background
9-
import androidx.compose.foundation.layout.Box
10-
import androidx.compose.foundation.layout.statusBarsPadding
11-
import androidx.compose.foundation.layout.systemBarsPadding
12-
import androidx.compose.material.MaterialTheme
13-
import androidx.compose.ui.Modifier
148
import com.linuxcommandlibrary.app.App
15-
import com.linuxcommandlibrary.app.ui.theme.LinuxTheme
16-
import com.linuxcommandlibrary.app.ui.theme.LocalCustomColors
179

1810
/* Copyright 2022 Simon Schubert
1911
*
@@ -38,25 +30,8 @@ class MainActivity : AppCompatActivity() {
3830
navigationBarStyle = SystemBarStyle.dark(android.graphics.Color.TRANSPARENT),
3931
)
4032
super.onCreate(savedInstanceState)
41-
42-
val deeplink = intent?.data?.toString()
43-
4433
setContent {
45-
LinuxTheme {
46-
Box(
47-
Modifier
48-
.background(MaterialTheme.colors.primary)
49-
.statusBarsPadding(),
50-
) {
51-
Box(
52-
Modifier
53-
.background(LocalCustomColors.current.navBarBackground)
54-
.systemBarsPadding(),
55-
) {
56-
App(initialDeeplink = deeplink)
57-
}
58-
}
59-
}
34+
App(initialDeeplink = intent?.data?.toString())
6035
}
6136
}
6237
}

composeApp/src/commonMain/kotlin/com/linuxcommandlibrary/app/App.kt

Lines changed: 12 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,14 @@ import androidx.compose.animation.fadeIn
66
import androidx.compose.animation.fadeOut
77
import androidx.compose.foundation.background
88
import androidx.compose.foundation.layout.Box
9-
import androidx.compose.foundation.layout.Column
109
import androidx.compose.foundation.layout.Row
11-
import androidx.compose.foundation.layout.Spacer
12-
import androidx.compose.foundation.layout.WindowInsets
1310
import androidx.compose.foundation.layout.fillMaxSize
1411
import androidx.compose.foundation.layout.fillMaxWidth
1512
import androidx.compose.foundation.layout.heightIn
13+
import androidx.compose.foundation.layout.navigationBarsPadding
1614
import androidx.compose.foundation.layout.padding
17-
import androidx.compose.foundation.layout.safeDrawing
1815
import androidx.compose.foundation.layout.size
19-
import androidx.compose.foundation.layout.windowInsetsBottomHeight
20-
import androidx.compose.foundation.layout.windowInsetsTopHeight
16+
import androidx.compose.foundation.layout.statusBarsPadding
2117
import androidx.compose.material.BottomNavigation
2218
import androidx.compose.material.BottomNavigationItem
2319
import androidx.compose.material.Icon
@@ -98,25 +94,16 @@ fun App(initialDeeplink: String? = null) {
9894
}
9995

10096
LinuxTheme {
101-
Column(modifier = Modifier.fillMaxSize()) {
102-
// Status bar area with primary color
103-
Spacer(
104-
modifier = Modifier
105-
.fillMaxWidth()
106-
.windowInsetsTopHeight(WindowInsets.safeDrawing)
107-
.background(MaterialTheme.colors.primary),
108-
)
109-
// Main content
110-
Box(modifier = Modifier.weight(1f)) {
111-
LinuxApp(initialDeeplink = initialDeeplink)
112-
}
113-
// Navigation bar area with white/surface color
114-
Spacer(
115-
modifier = Modifier
116-
.fillMaxWidth()
117-
.windowInsetsBottomHeight(WindowInsets.safeDrawing)
118-
.background(LocalCustomColors.current.navBarBackground),
119-
)
97+
Box(
98+
modifier = Modifier
99+
.fillMaxSize()
100+
.background(MaterialTheme.colors.primary)
101+
.statusBarsPadding()
102+
.background(LocalCustomColors.current.navBarBackground)
103+
.navigationBarsPadding()
104+
.background(MaterialTheme.colors.background),
105+
) {
106+
LinuxApp(initialDeeplink = initialDeeplink)
120107
}
121108
}
122109
}

0 commit comments

Comments
 (0)