Skip to content

Commit d688527

Browse files
committed
Clean up code
1 parent 91f95dd commit d688527

8 files changed

Lines changed: 7 additions & 24 deletions

File tree

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,5 @@ commands.txt
3030
commands_ignore.txt
3131
commands_improved.txt
3232
commands_processed.txt
33-
find_missing_commands.sh
33+
find_missing_commands.sh
34+
scripts

cli/src/commonMain/kotlin/com/linuxcommandlibrary/nativecli/TuiApp.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class TuiApp(private val terminal: Terminal) {
1414
private var running = true
1515
private var rawModeSupported = true
1616

17-
fun run(initialScreen: Screen = MainMenuScreen(terminal)) {
17+
fun run(initialScreen: Screen = MainMenuScreen()) {
1818
screenStack.add(initialScreen)
1919

2020
// Try to detect raw mode support

cli/src/commonMain/kotlin/com/linuxcommandlibrary/nativecli/components/SelectableList.kt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.linuxcommandlibrary.nativecli.components
22

3-
import com.github.ajalt.mordant.terminal.Terminal
43
import com.linuxcommandlibrary.nativecli.Theme
54

65
data class ListItem<T>(
@@ -9,7 +8,6 @@ data class ListItem<T>(
98
)
109

1110
class SelectableList<T>(
12-
private val terminal: Terminal,
1311
private val items: List<ListItem<T>>,
1412
private val pageSize: Int = 15,
1513
private var selectedIndex: Int = 0,
@@ -107,9 +105,3 @@ class SelectableList<T>(
107105
adjustScroll()
108106
}
109107
}
110-
111-
fun <T> Terminal.selectableList(
112-
items: List<ListItem<T>>,
113-
pageSize: Int = 15,
114-
selectedIndex: Int = 0,
115-
): SelectableList<T> = SelectableList(this, items, pageSize, selectedIndex)

cli/src/commonMain/kotlin/com/linuxcommandlibrary/nativecli/data/DataRepository.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ object DataRepository {
3535
.map { CommandInfo(it) }
3636
}
3737

38-
fun getCommandContent(name: String): String? = allCommands[name]
39-
4038
fun getCommandSections(name: String): List<CommandSection> {
4139
val content = allCommands[name] ?: return emptyList()
4240
return MarkdownParser.splitByHeaders(content, "# ").map { (title, sectionContent) ->
@@ -55,14 +53,10 @@ object DataRepository {
5553
}
5654
}.sortedBy { it.title }
5755

58-
fun getBasicContent(categoryId: String): String? = basicsData[categoryId]
59-
6056
fun getBasicInfo(categoryId: String): BasicInfo? {
6157
val content = basicsData[categoryId] ?: return null
6258
return MarkdownParser.parseBasic(content)
6359
}
6460

65-
fun getTipsContent(): String = tipsData
66-
6761
fun getTips(): List<TipInfo> = MarkdownParser.parseTips(tipsData)
6862
}

cli/src/commonMain/kotlin/com/linuxcommandlibrary/nativecli/screens/BasicCategoriesScreen.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.linuxcommandlibrary.nativecli.screens
22

33
import com.github.ajalt.mordant.input.KeyboardEvent
4-
import com.github.ajalt.mordant.terminal.Terminal
54
import com.linuxcommandlibrary.nativecli.Theme
65
import com.linuxcommandlibrary.nativecli.components.ListItem
76
import com.linuxcommandlibrary.nativecli.components.SelectableList
@@ -12,7 +11,7 @@ class BasicCategoriesScreen : Screen {
1211

1312
private val categories = DataRepository.getBasicCategories()
1413
private val items = categories.map { ListItem(it, it.title) }
15-
private val list = SelectableList(Terminal(), items, pageSize = 15)
14+
private val list = SelectableList(items, pageSize = 15)
1615

1716
override fun render(): String {
1817
val sb = StringBuilder()

cli/src/commonMain/kotlin/com/linuxcommandlibrary/nativecli/screens/MainMenuScreen.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.linuxcommandlibrary.nativecli.screens
22

33
import com.github.ajalt.mordant.input.KeyboardEvent
4-
import com.github.ajalt.mordant.terminal.Terminal
54
import com.linuxcommandlibrary.nativecli.Theme
65
import com.linuxcommandlibrary.nativecli.components.ListItem
76
import com.linuxcommandlibrary.nativecli.components.SelectableList
@@ -14,7 +13,7 @@ enum class MainMenuItem {
1413
EXIT,
1514
}
1615

17-
class MainMenuScreen(terminal: Terminal) : Screen {
16+
class MainMenuScreen : Screen {
1817

1918
private val items = listOf(
2019
ListItem(MainMenuItem.COMMANDS, "Commands"),
@@ -23,7 +22,7 @@ class MainMenuScreen(terminal: Terminal) : Screen {
2322
ListItem(MainMenuItem.EXIT, "Exit"),
2423
)
2524

26-
private val list = SelectableList(terminal, items, pageSize = 10)
25+
private val list = SelectableList(items, pageSize = 10)
2726

2827
override fun render(): String {
2928
val logoLines = listOf(

cli/src/commonMain/kotlin/com/linuxcommandlibrary/nativecli/screens/SearchScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ class SearchScreen : Screen {
2828

2929
items = commands.map { ListItem(it, it.name) }
3030
list = SelectableList(
31-
terminal = com.github.ajalt.mordant.terminal.Terminal(),
3231
items = items,
3332
pageSize = 15,
3433
)

cli/src/commonMain/kotlin/com/linuxcommandlibrary/nativecli/screens/TipsScreen.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.linuxcommandlibrary.nativecli.screens
22

33
import com.github.ajalt.mordant.input.KeyboardEvent
4-
import com.github.ajalt.mordant.terminal.Terminal
54
import com.linuxcommandlibrary.nativecli.Theme
65
import com.linuxcommandlibrary.nativecli.components.ListItem
76
import com.linuxcommandlibrary.nativecli.components.SelectableList
@@ -12,7 +11,7 @@ class TipsScreen : Screen {
1211

1312
private val tips = DataRepository.getTips()
1413
private val items = tips.map { ListItem(it, it.title) }
15-
private val list = SelectableList(Terminal(), items, pageSize = 15)
14+
private val list = SelectableList(items, pageSize = 15)
1615

1716
override fun render(): String {
1817
val sb = StringBuilder()

0 commit comments

Comments
 (0)