Skip to content

Commit 54e9c44

Browse files
chore: Switch to s for signature queryparam
1 parent 1a8b047 commit 54e9c44

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/UrlBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public function buildUrl(string $sourceUrl, ?Options $options = null): string
3838

3939
$signature = $this->generateSignature($unsignedUrl);
4040

41-
$signature = $optionsString === '' ? "?signature={$signature}" : "&signature={$signature}";
41+
$signature = $optionsString === '' ? "?s={$signature}" : "&s={$signature}";
4242

4343
return "{$unsignedUrl}{$signature}";
4444
}

tests/Unit/UrlBuilderTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@
236236
$builder = new UrlBuilder('https://images.example.com', $secret);
237237
$url = $builder->buildUrl('images/image.jpg', $options);
238238

239-
expect($url)->toBe('https://images.example.com/images/image.jpg?h=400&w=300&signature=zUweQjgXXIPf89xQ6ZwWKiR6oaKLrb8uY3NZWQz7xCY');
239+
expect($url)->toBe('https://images.example.com/images/image.jpg?h=400&w=300&s=zUweQjgXXIPf89xQ6ZwWKiR6oaKLrb8uY3NZWQz7xCY');
240240
});
241241

242242
test('can generate complex signed URLs', function (): void {
@@ -251,7 +251,7 @@
251251
$builder = new UrlBuilder('https://images.example.com', $secret);
252252
$url = $builder->buildUrl('images/image.jpg', $options);
253253

254-
expect($url)->toBe('https://images.example.com/images/image.jpg?border=5,ff0000,overlay&fm=png&q=80&signature=aENMpKwCgmLFxdo1KipXNVWsNvmOMbgxa6pGRI');
254+
expect($url)->toBe('https://images.example.com/images/image.jpg?border=5,ff0000,overlay&fm=png&q=80&s=aENMpKwCgmLFxdo1KipXNVWsNvmOMbgxa6pGRI');
255255
});
256256

257257
test('generates signature with unicode characters', function (): void {
@@ -268,5 +268,5 @@
268268
$builder = new UrlBuilder('https://images.example.com', $secret);
269269
$url = $builder->buildUrl('images/unicode-%E9%BD%90%E8%89%B2-0.png', $options);
270270

271-
expect($url)->toBe('https://images.example.com/images/unicode-%E9%BD%90%E8%89%B2-0.png?fit=contain&fm=avif&h=600&origin=main&q=90&w=600&signature=CWhpOSCFIJdXSZCqI0Nq7JhXW9RKQs42YPnAcNz0');
271+
expect($url)->toBe('https://images.example.com/images/unicode-%E9%BD%90%E8%89%B2-0.png?fit=contain&fm=avif&h=600&origin=main&q=90&w=600&s=CWhpOSCFIJdXSZCqI0Nq7JhXW9RKQs42YPnAcNz0');
272272
});

0 commit comments

Comments
 (0)