Skip to content

Commit dfeffee

Browse files
johnnynotsoluckyjohnnynotsolucky
committed
chore: Remove default https scheme
1 parent 928b8cf commit dfeffee

2 files changed

Lines changed: 23 additions & 23 deletions

File tree

‎src/UrlBuilder.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function buildUrl(string $sourceUrl, ?Options $options = null): string
2626
$options ??= new Options();
2727
$optionsString = (string) $options;
2828

29-
$unsignedUrl = "https://{$this->host}/{$sourceUrl}?{$optionsString}";
29+
$unsignedUrl = "{$this->host}/{$sourceUrl}?{$optionsString}";
3030

3131
if ($this->secret === null) {
3232
return $unsignedUrl;

‎tests/Unit/UrlBuilderTest.php‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
'watermarkPosition' => 'center',
1111
]);
1212

13-
$builder = new UrlBuilder('images.example.com');
13+
$builder = new UrlBuilder('https://images.example.com');
1414
$url = $builder->buildUrl('images/image.jpg', $options);
1515

1616
expect($url)->toBe('https://images.example.com/images/image.jpg?w=300&h=400&fit=fill&markpos=center');
@@ -19,14 +19,14 @@
1919
test('can build a basic URL without any options', function (): void {
2020
$options = createOptions();
2121

22-
$builder = new UrlBuilder('images.example.com');
22+
$builder = new UrlBuilder('https://images.example.com');
2323
$url = $builder->buildUrl('images/image.jpg', $options);
2424

2525
expect($url)->toBe('https://images.example.com/images/image.jpg?');
2626
});
2727

2828
test('can build URL with null options', function (): void {
29-
$builder = new UrlBuilder('images.example.com');
29+
$builder = new UrlBuilder('https://images.example.com');
3030
$url = $builder->buildUrl('images/image.jpg', null);
3131

3232
expect($url)->toBe('https://images.example.com/images/image.jpg?');
@@ -37,7 +37,7 @@
3737
'width' => 300,
3838
]);
3939

40-
$builder = new UrlBuilder('images.example.com');
40+
$builder = new UrlBuilder('https://images.example.com');
4141
$url = $builder->buildUrl('/images/image.jpg/', $options);
4242

4343
expect($url)->toBe('https://images.example.com/images/image.jpg?w=300');
@@ -51,7 +51,7 @@
5151
'format' => 'webp',
5252
]);
5353

54-
$builder = new UrlBuilder('images.example.com');
54+
$builder = new UrlBuilder('https://images.example.com');
5555
$url = $builder->buildUrl('images/image.jpg', $options);
5656

5757
expect($url)->toBe('https://images.example.com/images/image.jpg?w=300&h=400&q=85&fm=webp');
@@ -65,7 +65,7 @@
6565
'watermarkAlpha' => 50,
6666
]);
6767

68-
$builder = new UrlBuilder('images.example.com');
68+
$builder = new UrlBuilder('https://images.example.com');
6969
$url = $builder->buildUrl('images/image.jpg', $options);
7070

7171
expect($url)->toBe('https://images.example.com/images/image.jpg?w=300&h=400&markpos=center&markalpha=50');
@@ -81,7 +81,7 @@
8181
'blur' => 2,
8282
]);
8383

84-
$builder = new UrlBuilder('images.example.com');
84+
$builder = new UrlBuilder('https://images.example.com');
8585
$url = $builder->buildUrl('images/image.jpg', $options);
8686

8787
expect($url)->toBe('https://images.example.com/images/image.jpg?w=300&h=400&bri=10&con=15&sharp=3&blur=2');
@@ -94,7 +94,7 @@
9494
'filter' => 'grayscale',
9595
]);
9696

97-
$builder = new UrlBuilder('images.example.com');
97+
$builder = new UrlBuilder('https://images.example.com');
9898
$url = $builder->buildUrl('images/image.jpg', $options);
9999

100100
expect($url)->toBe('https://images.example.com/images/image.jpg?w=300&h=400&filt=grayscale');
@@ -104,7 +104,7 @@
104104
$options = createOptions();
105105
$options->setCrop(100, 200, 10, 20);
106106

107-
$builder = new UrlBuilder('images.example.com');
107+
$builder = new UrlBuilder('https://images.example.com');
108108
$url = $builder->buildUrl('images/image.jpg', $options);
109109

110110
expect($url)->toBe('https://images.example.com/images/image.jpg?crop=100,200,10,20');
@@ -115,7 +115,7 @@
115115
$options->setBackground('ffffff')
116116
->setBorder(5, 'ff0000', 'overlay');
117117

118-
$builder = new UrlBuilder('images.example.com');
118+
$builder = new UrlBuilder('https://images.example.com');
119119
$url = $builder->buildUrl('images/image.jpg', $options);
120120

121121
expect($url)->toBe('https://images.example.com/images/image.jpg?bg=ffffff&border=5,ff0000,overlay');
@@ -125,7 +125,7 @@
125125
$options = createOptions();
126126
$options->setInterlaced(true);
127127

128-
$builder = new UrlBuilder('images.example.com');
128+
$builder = new UrlBuilder('https://images.example.com');
129129
$url = $builder->buildUrl('images/image.jpg', $options);
130130

131131
expect($url)->toBe('https://images.example.com/images/image.jpg?interlace=1');
@@ -135,7 +135,7 @@
135135
$options = createOptions();
136136
$options->setFit('contain');
137137

138-
$builder = new UrlBuilder('images.example.com');
138+
$builder = new UrlBuilder('https://images.example.com');
139139
$url = $builder->buildUrl('images/image.jpg', $options);
140140

141141
expect($url)->toBe('https://images.example.com/images/image.jpg?fit=contain');
@@ -146,7 +146,7 @@
146146
$options->setOrientation(90)
147147
->setFlip('h');
148148

149-
$builder = new UrlBuilder('images.example.com');
149+
$builder = new UrlBuilder('https://images.example.com');
150150
$url = $builder->buildUrl('images/image.jpg', $options);
151151

152152
expect($url)->toBe('https://images.example.com/images/image.jpg?or=90&flip=h');
@@ -156,7 +156,7 @@
156156
$options = createOptions();
157157
$options->setDevicePixelRatio(2);
158158

159-
$builder = new UrlBuilder('images.example.com');
159+
$builder = new UrlBuilder('https://images.example.com');
160160
$url = $builder->buildUrl('images/image.jpg', $options);
161161

162162
expect($url)->toBe('https://images.example.com/images/image.jpg?dpr=2');
@@ -166,7 +166,7 @@
166166
$options = createOptions();
167167
$options->setGamma(1.5);
168168

169-
$builder = new UrlBuilder('images.example.com');
169+
$builder = new UrlBuilder('https://images.example.com');
170170
$url = $builder->buildUrl('images/image.jpg', $options);
171171

172172
expect($url)->toBe('https://images.example.com/images/image.jpg?gam=1.5');
@@ -176,7 +176,7 @@
176176
$options = createOptions();
177177
$options->setPixelate(10);
178178

179-
$builder = new UrlBuilder('images.example.com');
179+
$builder = new UrlBuilder('https://images.example.com');
180180
$url = $builder->buildUrl('images/image.jpg', $options);
181181

182182
expect($url)->toBe('https://images.example.com/images/image.jpg?pixel=10');
@@ -186,7 +186,7 @@
186186
$options = createOptions();
187187
$options->setWatermarkPath('/watermarks/logo.png');
188188

189-
$builder = new UrlBuilder('images.example.com');
189+
$builder = new UrlBuilder('https://images.example.com');
190190
$url = $builder->buildUrl('images/image.jpg', $options);
191191

192192
expect($url)->toBe('https://images.example.com/images/image.jpg?mark=/watermarks/logo.png');
@@ -197,7 +197,7 @@
197197
$options->setWatermarkWidth(100)
198198
->setWatermarkHeight(50);
199199

200-
$builder = new UrlBuilder('images.example.com');
200+
$builder = new UrlBuilder('https://images.example.com');
201201
$url = $builder->buildUrl('images/image.jpg', $options);
202202

203203
expect($url)->toBe('https://images.example.com/images/image.jpg?markw=100&markh=50');
@@ -209,7 +209,7 @@
209209
->setWatermarkYOffset(20)
210210
->setWatermarkPadding(5);
211211

212-
$builder = new UrlBuilder('images.example.com');
212+
$builder = new UrlBuilder('https://images.example.com');
213213
$url = $builder->buildUrl('images/image.jpg', $options);
214214

215215
expect($url)->toBe('https://images.example.com/images/image.jpg?markx=10&marky=20&markpad=5');
@@ -219,7 +219,7 @@
219219
$options = createOptions();
220220
$options->setWatermarkFit('contain');
221221

222-
$builder = new UrlBuilder('images.example.com');
222+
$builder = new UrlBuilder('https://images.example.com');
223223
$url = $builder->buildUrl('images/image.jpg', $options);
224224

225225
expect($url)->toBe('https://images.example.com/images/image.jpg?markfit=contain');
@@ -233,7 +233,7 @@
233233

234234
$secret = 'my-secret-value';
235235

236-
$builder = new UrlBuilder('images.example.com', $secret);
236+
$builder = new UrlBuilder('https://images.example.com', $secret);
237237
$url = $builder->buildUrl('images/image.jpg', $options);
238238

239239
expect($url)->toBe('https://images.example.com/images/image.jpg?w=300&h=400&signature=S0b0bvBhc0kh2L6WRhcYGaRVT1LsuzWwONsdROoBk');
@@ -248,7 +248,7 @@
248248

249249
$secret = 'my-secret-value';
250250

251-
$builder = new UrlBuilder('images.example.com', $secret);
251+
$builder = new UrlBuilder('https://images.example.com', $secret);
252252
$url = $builder->buildUrl('images/image.jpg', $options);
253253

254254
expect($url)->toBe('https://images.example.com/images/image.jpg?border=5,ff0000,overlay&q=80&fm=png&signature=NBzER5uyLXXVZGFMAXWjthvfYWCVaj754FoMWujdaeI');

0 commit comments

Comments
 (0)