Stop using events for label re-rerendering

That usage was based on a misunderstanding of JavaFX events; they are meant for
handling user UI interactions, and the label updating action does not require
any action-at-a-distance, event bubbling, or UI interaction checking, so it's
simpler to just call the geometry manager method directly.

Author: garfieldnate

src/main/java/edu/umich/soar/svsviewer/SVSViewerEvent.java

@@ -89,7 +89,7 @@ public void initialize() {
     viewerScene.setCamera(camera);
 
     for (Transform t : List.of(cameraYaw, cameraPitch, cameraRoll, cameraTranslation)) {
-      t.setOnTransformChanged(value -> requestSceneRerender());
+      t.setOnTransformChanged(value -> geometryManager.requestSceneRerender());
     }
 
     // Handle keyboard events
@@ -176,8 +176,6 @@ public void initialize() {
 
     this.geometryManager =
         new GeometryManager(preferences, rootPane, shapeGroup, this::showMessage);
-    viewerScene.addEventFilter(
-        SVSViewerEvent.SCENE_RERENDER_REQUESTED, e -> geometryManager.updateLabelPositions());
 
     Consumer<String> inputProcessor =
         (String line) -> {
@@ -220,15 +218,7 @@ public void initialize() {
   }
 
   private void rerenderSceneOnChange(ObservableValue<?> observable) {
-    observable.addListener((obs, oldValue, newValue) -> requestSceneRerender());
-  }
-
-  private void requestSceneRerender() {
-    Platform.runLater(
-        () ->
-            Event.fireEvent(
-                viewerScene,
-                new SVSViewerEvent(viewerScene, SVSViewerEvent.SCENE_RERENDER_REQUESTED)));
+    observable.addListener((obs, oldValue, newValue) -> geometryManager.requestSceneRerender());
   }
 
   private void initMessageStack(VBox messageStack) {

src/main/java/edu/umich/soar/svsviewer/SceneController.java

@@ -2,7 +2,6 @@
 
 import com.github.quickhull3d.Point3d;
 import com.github.quickhull3d.QuickHull3D;
-import edu.umich.soar.svsviewer.SVSViewerEvent;
 import edu.umich.soar.svsviewer.SceneController;
 import edu.umich.soar.svsviewer.scene.Geometry;
 import edu.umich.soar.svsviewer.scene.GeometryManager;
@@ -141,13 +140,10 @@ public void interpret(GeometryManager geoManager, SceneController sceneControlle
       }
     }
     for (SVSScene scene : rerenderedScenes.values()) {
-      //      TODO: technically only need to update label for the geometries that were changed
-      Node sceneRoot = scene.root();
-      Platform.runLater(
-          () ->
-              Event.fireEvent(
-                  sceneRoot,
-                  new SVSViewerEvent(sceneRoot, SVSViewerEvent.SCENE_RERENDER_REQUESTED)));
+      // TODO: technically only need to update label for the scenes/geometries that were changed
+      // Node sceneRoot = scene.root();
+      // geoManager.requestSceneRerender(scene);
+      geoManager.requestSceneRerender();
     }
   }
 

src/main/java/edu/umich/soar/svsviewer/command/UpdateGeometryCommand.java

@@ -14,6 +14,7 @@
 import java.util.List;
 import java.util.function.Consumer;
 
+import javafx.application.Platform;
 import javafx.scene.Group;
 import javafx.scene.Node;
 import javafx.scene.layout.Pane;
@@ -279,8 +280,13 @@ public void addGeometry(NameMatcher sceneMatcher, String geometryName) {
     }
   }
 
+  public void requestSceneRerender() {
+    Platform.runLater(this::updateLabelPositions);
+  }
+
   public void updateLabelPositions() {
-    //    System.out.println("Updating label positions...");
+    // TODO: would be nice to manage labels in a dedicated class
+    // System.out.println("Updating label positions...");
     // TODO: should be done only for the updated scene
     scenes
         .values()