Skip to content

Commit c2bc561

Browse files
committed
ci: use official socketdev/action for Socket Firewall setup
Replace the hand-rolled `npm install -g sfw` in all three sfw smoke jobs with the official setup action (socketdev/action@v1.3.2, mode: firewall-free). Why: - It's the documented GitHub Actions integration for Socket Firewall Free and wires up sfw routing correctly, rather than relying on an ad-hoc global npm install. This is the right mitigation for the class of Wrapper-Mode routing gaps where sfw can fail to proxy fetches from files.pythonhosted.org (tracked upstream as ENG-4871) -- exactly the "no interception" symptom that made the python job look like a no-op. - The Python jobs no longer need actions/setup-node at all (the action provides sfw directly), so those steps are dropped; the npm fixture job keeps setup-node since `npm install` needs it. Setup mode is firewall-free (anonymous, no API token) -- unchanged, and the reason this is safe to run on Dependabot/untrusted PRs. Our setup is Wrapper Mode + free edition + no CodeArtifact, so the Registry Mode + CodeArtifact `uv sync`/`uv lock` issue (CE-171) does not apply. Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
1 parent cfd5f47 commit c2bc561

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

.github/workflows/dependabot-review.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,12 @@ jobs:
9898
with:
9999
python-version: "3.12"
100100

101-
- uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af
101+
# Official Socket setup action (free edition). Installs sfw and wires up
102+
# routing correctly -- preferred over a hand-rolled `npm install -g sfw`.
103+
- name: Set up Socket Firewall (free)
104+
uses: socketdev/action@ba6de6cc0565af1f42295590380973573297e31f # v1.3.2
102105
with:
103-
node-version: "20"
104-
105-
- name: Install Socket Firewall
106-
run: npm install -g sfw
106+
mode: firewall-free
107107

108108
- name: Install uv
109109
run: python -m pip install --upgrade pip uv
@@ -145,8 +145,10 @@ jobs:
145145
with:
146146
node-version: "20"
147147

148-
- name: Install Socket Firewall
149-
run: npm install -g sfw
148+
- name: Set up Socket Firewall (free)
149+
uses: socketdev/action@ba6de6cc0565af1f42295590380973573297e31f # v1.3.2
150+
with:
151+
mode: firewall-free
150152

151153
- name: Install fixture through Socket Firewall
152154
working-directory: tests/e2e/fixtures/simple-npm
@@ -167,12 +169,10 @@ jobs:
167169
with:
168170
python-version: "3.12"
169171

170-
- uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af
172+
- name: Set up Socket Firewall (free)
173+
uses: socketdev/action@ba6de6cc0565af1f42295590380973573297e31f # v1.3.2
171174
with:
172-
node-version: "20"
173-
174-
- name: Install Socket Firewall
175-
run: npm install -g sfw
175+
mode: firewall-free
176176

177177
- name: Install fixture through Socket Firewall
178178
working-directory: tests/e2e/fixtures/simple-pypi

0 commit comments

Comments
 (0)