Merge branch 'fix/pref-error-msg' of https://github.com/solidos/solid-ui into fix/pref-error-msg

Author: SharonStrats

src/login/login.ts

@@ -1060,7 +1060,7 @@ export async function getUserRoles (): Promise<Array<NamedNode>> {
   try {
     const { me, preferencesFile, preferencesFileError } = await ensureLoadedPreferences({ me: currentUser })
     if (!preferencesFile || preferencesFileError) {
-      return []
+      throw new Error(preferencesFileError || 'Unable to load user preferences file.')
     }
     return solidLogicSingleton.store.each(
       me,

test/unit/login/login.test.ts

@@ -11,3 +11,29 @@ describe('ensureLoggedIn', () => {
     expect(testLogin.ensureLoggedIn({})).toBeInstanceOf(Object)
   })
 })
+
+describe('getUserRoles', () => {
+  afterEach(() => {
+    jest.restoreAllMocks()
+    jest.resetModules()
+  })
+
+  it('returns [] and does not load preferences when current user is missing', async () => {
+    const solidLogic = require('solid-logic')
+
+    const currentUserSpy = jest
+      .spyOn(solidLogic.authn, 'currentUser')
+      .mockReturnValue(null)
+    const loadPreferencesSpy = jest.spyOn(
+      solidLogic.solidLogicSingleton.profile,
+      'loadPreferences'
+    )
+
+    const loginModule = require('../../../src/login/login')
+    const roles = await loginModule.getUserRoles()
+
+    expect(currentUserSpy).toHaveBeenCalled()
+    expect(roles).toEqual([])
+    expect(loadPreferencesSpy).not.toHaveBeenCalled()
+  })
+})