Skip to content

Commit c397169

Browse files
author
Tim Berners-Lee
committed
switch deleteButtonWithCheck to use a red circle minus icon consistent with the new green plus icon
1 parent 2372523 commit c397169

1 file changed

Lines changed: 16 additions & 8 deletions

File tree

lib/widgets.js

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -178,13 +178,20 @@ widgetModule.setImage = function (element, x) {
178178
// @@ Supress check if command key held down?
179179
//
180180
widgetModule.deleteButtonWithCheck = function (dom, container, noun, deleteFunction) {
181-
var delButton = dom.createElement('button')
182-
container.appendChild(delButton)
183-
delButton.textContent = '-'
181+
var minusIconURI = UI.icons.iconBase + 'noun_2188_red.svg' // white minus in red #cc0000 circle
182+
183+
//var delButton = dom.createElement('button')
184+
185+
var img = dom.createElement('img')
186+
img.setAttribute('src', minusIconURI) // plus sign
187+
img.setAttribute('style', 'margin: 0.2em; width: 1em; height:1em')
188+
img.title = 'Remove this ' + noun
189+
var delButton = img
184190

191+
container.appendChild(delButton)
185192
container.setAttribute('class', 'hoverControl') // See tabbedtab.css (sigh global CSS)
186193
delButton.setAttribute('class', 'hoverControlHide')
187-
delButton.setAttribute('style', 'color: red; margin-right: 0.3em; foat:right; text-align:right')
194+
// delButton.setAttribute('style', 'color: red; margin-right: 0.3em; foat:right; text-align:right')
188195
delButton.addEventListener('click', function (e) {
189196
container.removeChild(delButton) // Ask -- are you sure?
190197
var cancelButton = dom.createElement('button')
@@ -404,6 +411,7 @@ widgetModule.field[UI.ns.ui('Multiple').uri] = function (
404411
dom, container, already, subject, form, store, callback) {
405412
// var plusIcon = UI.icons.originalIconBase + 'tango/22-list-add.png' // blue plus
406413
var plusIconURI = UI.icons.iconBase + 'noun_19460_green.svg' // white plus in green circle
414+
407415
var kb = UI.store
408416
kb.updater = kb.updater || new $rdf.UpdateManager(kb)
409417
var box = dom.createElement('table')
@@ -483,8 +491,8 @@ widgetModule.field[UI.ns.ui('Multiple').uri] = function (
483491
UI.utils.label(property)
484492

485493
values.map(function (obj) { addItem(null, obj) })
486-
487-
while (values.length < min) {
494+
var extra = min - values.length
495+
for (var j=0; j < extra; j++) {
488496
console.log("Adding extra: min " + min )
489497
addItem() // Add blanks if less than minimum
490498
}
@@ -541,11 +549,11 @@ widgetModule.fieldParams[UI.ns.ui('FloatField').uri].pattern =
541549
widgetModule.fieldParams[UI.ns.ui('NamedNodeURIField').uri] = { namedNode: true}
542550
widgetModule.fieldParams[UI.ns.ui('TextField').uri] = { }
543551

544-
widgetModule.fieldParams[UI.ns.ui('PhoneField').uri] = { 'size': 12, 'uriPrefix': 'tel:' }
552+
widgetModule.fieldParams[UI.ns.ui('PhoneField').uri] = { 'size': 20, 'uriPrefix': 'tel:' }
545553
widgetModule.fieldParams[UI.ns.ui('PhoneField').uri].pattern =
546554
/^\s*\+?[ 0-9-]+[0-9]\s*$/
547555

548-
widgetModule.fieldParams[UI.ns.ui('EmailField').uri] = { 'size': 20, 'uriPrefix': 'mailto:' }
556+
widgetModule.fieldParams[UI.ns.ui('EmailField').uri] = { 'size': 30, 'uriPrefix': 'mailto:' }
549557
widgetModule.fieldParams[UI.ns.ui('EmailField').uri].pattern =
550558
/^\s*.*@.*\..*\s*$/ // @@ Get the right regexp here
551559

0 commit comments

Comments
 (0)