Fixed two issues with Regex that affect .NET 6 or less. Improved unit tests to test for .NET 5, 6 amd 7. Removed .NET 8 from list of target framewors, as this does not require any changes to .NET 7 code.

Author: cnayoung

Solidsoft.Reply.Parsers.Gs1Ai.Tests/Solidsoft.Reply.Parsers.Gs1Ai.Tests.csproj

@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
-	<LangVersion>12.0</LangVersion>
+	  <TargetFrameworks>net7.0;net6.0;net5.0</TargetFrameworks>
+	  <LangVersion>12.0</LangVersion>
 	<Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <AssemblyName>$(MSBuildProjectName)</AssemblyName>
@@ -13,6 +13,24 @@
     <CodeAnalysisRuleSet>$(SolutionDir)StyleCopAnalyzersDefault.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
 
+  <ItemGroup>
+    <Compile Remove="Drivers\**" />
+    <Compile Remove="Properties\**" />
+    <Compile Remove="Support\**" />
+    <EmbeddedResource Remove="Drivers\**" />
+    <EmbeddedResource Remove="Properties\**" />
+    <EmbeddedResource Remove="Support\**" />
+    <None Remove="Drivers\**" />
+    <None Remove="Properties\**" />
+    <None Remove="Support\**" />
+    <ReqnrollFeatureFiles Remove="Drivers\**" />
+    <ReqnrollFeatureFiles Remove="Properties\**" />
+    <ReqnrollFeatureFiles Remove="Support\**" />
+    <ReqnrollObsoleteCodeBehindFiles Remove="Drivers\**" />
+    <ReqnrollObsoleteCodeBehindFiles Remove="Properties\**" />
+    <ReqnrollObsoleteCodeBehindFiles Remove="Support\**" />
+  </ItemGroup>
+
   <ItemGroup>
     <None Remove="stylecop.json" />
   </ItemGroup>
@@ -22,20 +40,14 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
-    <PackageReference Include="Reqnroll.xUnit" Version="2.2.1" />
-    <PackageReference Include="xunit" Version="2.9.3" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="3.0.1">
+    <PackageReference Include="FluentAssertions" Version="[7.1.0]" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
+    <PackageReference Include="Reqnroll.xUnit" Version="2.3.0" />
+    <PackageReference Include="xunit" Version="2.4.2" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="FluentAssertions" Version="[7.1.0]" />
-  </ItemGroup>
-
-  <ItemGroup>
-    <Folder Include="Drivers\" />
-    <Folder Include="Properties\" />
-    <Folder Include="Support\" />
   </ItemGroup>
 
   <ItemGroup>

Solidsoft.Reply.Parsers.Gs1Ai/Descriptors/IbanDescriptor.cs

@@ -103,7 +103,7 @@ class IbanDescriptor(
     /// <summary>
     /// Regular expression for Bosnia and Herzegovina IBAN.
     /// </summary>
-    private static readonly Regex BosniaAndHerzegovinaIbanRegex = new (@"^BE\d{2}\d{16}$", RegexOptions.None);
+    private static readonly Regex BosniaAndHerzegovinaIbanRegex = new (@"^BA\d{2}\d{16}$", RegexOptions.None);
 
     /// <summary>
     /// Regular expression for Brazil IBAN.

Solidsoft.Reply.Parsers.Gs1Ai/EntityResolver.cs

@@ -339,7 +339,7 @@ internal static class EntityResolver {
     /// <summary>
     ///     Returns a regular expression for matching a GS1 UIC with Extension 1 and Imported index.
     /// </summary>
-    private static readonly Regex Gs1UicWithExtension1AndImportedIndexRegex = new (@"^\d" + CharacterSet82 + $"{Eu2018574ImporterIndexCharacterSet}$", RegexOptions.None);
+    private static readonly Regex Gs1UicWithExtension1AndImportedIndexRegex = new (@"^\d" + CharacterSet82 + @"{2}" + $"{Eu2018574ImporterIndexCharacterSet}$", RegexOptions.None);
 
     /// <summary>
     ///     Returns a regular expression for six-digit date representation - YYMMDD.

Solidsoft.Reply.Parsers.Gs1Ai/Solidsoft.Reply.Parsers.Gs1Ai.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-	<TargetFrameworks>net8.0;net7.0;net6.0;netstandard2.0</TargetFrameworks>
+	<TargetFrameworks>net7.0;net6.0;netstandard2.0</TargetFrameworks>
 	<LangVersion>12.0</LangVersion>
 	<ImplicitUsings>enable</ImplicitUsings>
 	<Nullable>enable</Nullable>