SONARJAVA-6208 S2699: Add approve to assertion method name pattern (#5570)

Co-authored-by: sonar-review-alpha[bot] <266116024+sonar-review-alpha[bot]@users.noreply.github.com>

Author: NoemieBenard

its/autoscan/src/test/resources/autoscan/diffs/diff_S2699.json

@@ -1,6 +1,6 @@
 {
   "ruleKey": "S2699",
   "hasTruePositives": true,
-  "falseNegatives": 157,
+  "falseNegatives": 158,
   "falsePositives": 1
 }

java-checks-test-sources/default/pom.xml

@@ -1016,6 +1016,12 @@
       <artifactId>junit-platform-suite</artifactId>
       <scope>provided</scope>
     </dependency>
+    <dependency>
+      <groupId>org.approvej</groupId>
+      <artifactId>core</artifactId>
+      <version>1.6.0</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <profiles>

java-checks-test-sources/default/src/test/java/checks/tests/AssertionsInTestsCheck/ApproveJ.java

@@ -0,0 +1,32 @@
+package checks.tests.AssertionsInTestsCheck;
+
+import java.time.LocalDate;
+import org.junit.jupiter.api.Test;
+
+import static org.approvej.ApprovalBuilder.approve;
+import static org.approvej.print.MultiLineStringPrintFormat.multiLineString;
+
+class ApproveJTest {
+
+  @Test
+  void contains_no_assertions() { // Noncompliant
+  }
+
+  public String hello() {return "hello";}
+
+  @Test
+  void approve_string() {
+    String result = hello();
+    approve(result)
+      .byFile();
+  }
+
+  public record Person(String name, LocalDate birthDate) {}
+
+  @Test
+  void approve_person() {
+    Person jane = new Person("Jane Doe", LocalDate.of(1990, 1, 1));
+    approve(jane).named("jane").printedAs(multiLineString()).byFile();
+  }
+
+}

java-checks/src/main/java/org/sonar/java/checks/helpers/UnitTestUtils.java

@@ -41,7 +41,7 @@ public final class UnitTestUtils {
 
   private static final String ORG_JUNIT_TEST = "org.junit.Test";
   public static final Pattern ASSERTION_METHODS_PATTERN = Pattern.compile(
-    "(assert|verify|fail|should|check|expect|validate|andExpect).*" +
+    "(assert|verify|fail|should|check|expect|validate|andExpect|approve).*" +
     // Eclipse Vert.x with JUnit 5 (VertxTestContext)
       "|laxCheckpoint|succeedingThenComplete");
   private static final Pattern TEST_METHODS_PATTERN = Pattern.compile("test.*|.*Test");

java-checks/src/test/java/org/sonar/java/checks/tests/AssertionsInTestsCheckTest.java

@@ -64,6 +64,7 @@ void setup() {
     "JMockit",
     "Awaitility",
     "AssertJ",
+    "ApproveJ",
     "Custom"
   })
   void test(String framework) {

sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S2699.html

@@ -3,6 +3,7 @@ <h2>Why is this an issue?</h2>
 code under test.</p>
 <p>This rule raises an exception when no assertions from any of the following known frameworks are found in a test:</p>
 <ul>
+  <li>ApproveJ</li>
   <li>AssertJ</li>
   <li>Awaitility</li>
   <li>EasyMock</li>