Improve string formatting

chapterjason · chapterjason · commit b131fdd7d14c · 2025-05-29T17:19:29.000+02:00
diff --git a/src/Manager/ScreenManager.php b/src/Manager/ScreenManager.php
@@ -21,9 +21,9 @@ public function __construct(
     ) {
     }
 
-    public function generateScreenName(ScreenInterface $screen): string
+    private function generateScreenName(ScreenInterface $screen): string
     {
-        return hash('sha256', $this->getBaseDirectory().$screen->getName().implode('', $screen->getCommand()));
+        return hash('sha256', \sprintf('%s%s%s', $this->getBaseDirectory(), $screen->getName(), implode('', $screen->getCommand())));
     }
 
     private function getLogDirectory(): string

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,9 @@ public function __construct(`
`21`	`21`	`) {`
`22`	`22`	`}`
`23`	`23`
`24`		`- public function generateScreenName(ScreenInterface $screen): string`
	`24`	`+ private function generateScreenName(ScreenInterface $screen): string`
`25`	`25`	`{`
`26`		`- return hash('sha256', $this->getBaseDirectory().$screen->getName().implode('', $screen->getCommand()));`
	`26`	`+ return hash('sha256', \sprintf('%s%s%s', $this->getBaseDirectory(), $screen->getName(), implode('', $screen->getCommand())));`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`private function getLogDirectory(): string`