Skip to content

Commit f8e9ff8

Browse files
committed
fixed more formatting issues
Added size checks for enums
1 parent b957995 commit f8e9ff8

3 files changed

Lines changed: 19 additions & 9 deletions

File tree

ci-rust.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,12 @@ run_step() {
6464
cargo fmt --all -- --check || { print_error "Formatting check failed"; return 1; }
6565
print_success "Formatting check passed"
6666
;;
67+
fmt-fix)
68+
print_step "Fix formatting"
69+
cd "$LIQUIDCAN_RUST_DIR"
70+
cargo fmt --all || { print_error "Formatting fix failed"; return 1; }
71+
print_success "Formatting fixed"
72+
;;
6773

6874
clippy)
6975
print_step "Run clippy"

liquidcan_rust/src/message_conversion.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ mod tests {
3333
use crate::CanMessageFrame;
3434
use crate::can_message::CanMessage;
3535
use crate::payloads;
36-
use zerocopy::FromZeros;
3736
use crate::payloads::FieldStatus;
37+
use zerocopy::FromZeros;
3838

3939
fn test_round_trip(msg: CanMessage) {
4040
let can_data: CanMessageFrame = msg.clone().into();
@@ -193,7 +193,7 @@ mod tests {
193193
fn test_field_get_res() {
194194
let payload = payloads::FieldGetResPayload {
195195
field_id: 21,
196-
field_status:FieldStatus::Ok,
196+
field_status: FieldStatus::Ok,
197197
value: [0xCC; 61],
198198
};
199199
let msg = CanMessage::FieldGetRes { payload };
@@ -213,7 +213,7 @@ mod tests {
213213
fn test_field_id_lookup_res() {
214214
let payload = payloads::FieldIDLookupResPayload {
215215
field_id: 22,
216-
field_status:FieldStatus::Ok,
216+
field_status: FieldStatus::Ok,
217217
field_type: payloads::CanDataType::Float32,
218218
};
219219
let msg = CanMessage::FieldIDLookupRes { payload };

liquidcan_rust/src/payloads.rs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ pub struct ParameterSetConfirmationPayload {
9292
}
9393
#[derive(Specifier, Debug, Copy, Clone, PartialEq, Eq, Immutable, TryFromBytes, IntoBytes)]
9494
#[repr(u8)]
95-
pub enum FieldStatus{
95+
pub enum FieldStatus {
9696
Ok = 0,
9797
NotFound = 1,
9898
}
@@ -106,9 +106,9 @@ pub struct FieldGetReqPayload {
106106
#[derive(Debug, Clone, TryFromBytes, IntoBytes, Immutable, PartialEq)]
107107
#[repr(C, packed)]
108108
pub struct FieldGetResPayload {
109-
pub field_id: u8, // Field identifier
109+
pub field_id: u8, // Field identifier
110110
pub field_status: FieldStatus, // Status of the get operation
111-
pub value: [u8; 61], // Field value
111+
pub value: [u8; 61], // Field value
112112
}
113113

114114
#[derive(Debug, Clone, FromBytes, IntoBytes, Immutable, PartialEq)]
@@ -121,9 +121,9 @@ pub struct FieldIDLookupReqPayload {
121121
#[derive(Debug, Clone, TryFromBytes, IntoBytes, Immutable, PartialEq)]
122122
#[repr(C, packed)]
123123
pub struct FieldIDLookupResPayload {
124-
pub field_id: u8, // Field ID
124+
pub field_id: u8, // Field ID
125125
pub field_status: FieldStatus, // Status of the lookup operation
126-
pub field_type: CanDataType, // Field Datatype
126+
pub field_type: CanDataType, // Field Datatype
127127
}
128128

129129
// Important: only derives TryFromBytes because bool doesn't derive FromBytes
@@ -139,7 +139,7 @@ pub struct ParameterSetLockPayload {
139139
pub struct ParameterSetLockConfirmationPayload {
140140
pub parameter_id: u8, // Parameter identifier to lock
141141
pub parameter_lock: ParameterLockStatus, // Lock status (0=unlocked, 1=locked)
142-
pub field_status: FieldStatus // Status of the parameter
142+
pub field_status: FieldStatus, // Status of the parameter
143143
}
144144

145145
static_assertions::const_assert_eq!(size_of::<NodeInfoResPayload>(), 63);
@@ -156,3 +156,7 @@ static_assertions::const_assert_eq!(size_of::<FieldIDLookupReqPayload>(), 61);
156156
static_assertions::const_assert_eq!(size_of::<FieldIDLookupResPayload>(), 3);
157157
static_assertions::const_assert_eq!(size_of::<ParameterSetLockConfirmationPayload>(), 3);
158158
static_assertions::const_assert_eq!(size_of::<ParameterSetLockPayload>(), 2);
159+
static_assertions::const_assert_eq!(size_of::<FieldStatus>(), 1);
160+
static_assertions::const_assert_eq!(size_of::<CanDataType>(), 1);
161+
static_assertions::const_assert_eq!(size_of::<ParameterSetStatus>(), 1);
162+
static_assertions::const_assert_eq!(size_of::<ParameterLockStatus>(), 1);

0 commit comments

Comments
 (0)