dense right matmul

Author: dance858

CMakeLists.txt

@@ -1,6 +1,7 @@
 cmake_minimum_required(VERSION 3.15)
 project(DNLP_Diff_Engine C)
 set(CMAKE_C_STANDARD 99)
+set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 
 set(DIFF_ENGINE_VERSION_MAJOR 0)
 set(DIFF_ENGINE_VERSION_MINOR 1)

include/bivariate.h

@@ -40,6 +40,8 @@ expr *new_left_matmul_dense(expr *u, int m, int n, const double *data);
 /* Right matrix multiplication: f(x) @ A where A is a constant matrix */
 expr *new_right_matmul(expr *u, const CSR_Matrix *A);
 
+expr *new_right_matmul_dense(expr *u, int m, int n, const double *data);
+
 /* Constant scalar multiplication: a * f(x) where a is a constant double */
 expr *new_const_scalar_mult(double a, expr *child);
 

src/bivariate/right_matmul.c

@@ -17,9 +17,7 @@
  */
 #include "affine.h"
 #include "bivariate.h"
-#include "subexpr.h"
 #include "utils/CSR_Matrix.h"
-#include "utils/linalg_sparse_matmuls.h"
 #include <stdlib.h>
 
 /* This file implements the atom 'right_matmul' corresponding to the operation y =
@@ -41,3 +39,24 @@ expr *new_right_matmul(expr *u, const CSR_Matrix *A)
     free(work_transpose);
     return node;
 }
+
+expr *new_right_matmul_dense(expr *u, int m, int n, const double *data)
+{
+    /* We express: u @ A = (A^T @ u^T)^T
+       A is m x n, so A^T is n x m. */
+    double *AT = (double *) malloc(n * m * sizeof(double));
+    for (int i = 0; i < m; i++)
+    {
+        for (int j = 0; j < n; j++)
+        {
+            AT[j * m + i] = data[i * n + j];
+        }
+    }
+
+    expr *u_transpose = new_transpose(u);
+    expr *left_matmul_node = new_left_matmul_dense(u_transpose, m, n, AT);
+    expr *node = new_transpose(left_matmul_node);
+
+    free(AT);
+    return node;
+}

tests/jacobian_tests/test_prod.h

@@ -4,6 +4,7 @@
 #include "minunit.h"
 #include "other.h"
 #include "test_helpers.h"
+#include "affine.h"
 
 const char *test_jacobian_prod_no_zero(void)
 {