fixed out of bounds access on test

Author: dance858

include/affine.h

@@ -9,7 +9,7 @@ expr *new_linear(expr *u, const CSR_Matrix *A);
 expr *new_add(expr *left, expr *right);
 expr *new_sum(expr *child, int axis);
 
-expr *new_constant(int d1, int d2, const double *values);
+expr *new_constant(int d1, int d2, int n_vars, const double *values);
 expr *new_variable(int d1, int d2, int var_id, int n_vars);
 
 #endif /* AFFINE_H */

src/affine/constant.c

@@ -14,9 +14,9 @@ static bool is_affine(expr *node)
     return true; /* constant is affine */
 }
 
-expr *new_constant(int d1, int d2, const double *values)
+expr *new_constant(int d1, int d2, int n_vars, const double *values)
 {
-    expr *node = new_expr(d1, d2, node->n_vars);
+    expr *node = new_expr(d1, d2, n_vars);
     if (!node) return NULL;
 
     /* Copy constant values */

tests/forward_pass/affine/test_add.h

@@ -12,7 +12,7 @@ const char *test_addition()
     double u[2] = {3.0, 4.0};
     double c[2] = {1.0, 2.0};
     expr *var = new_variable(2, 1, 0, 2);
-    expr *const_node = new_constant(2, 1, c);
+    expr *const_node = new_constant(2, 1, 0, c);
     expr *sum = new_add(var, const_node);
     sum->forward(sum, u);
     double expected[2] = {4.0, 6.0};

tests/forward_pass/affine/test_sum.h

@@ -17,7 +17,7 @@ const char *test_sum_axis_neg1()
        Stored as: [1, 2, 3, 4, 5, 6]
     */
     double values[6] = {1.0, 2.0, 3.0, 4.0, 5.0, 6.0};
-    expr *const_node = new_constant(3, 2, values);
+    expr *const_node = new_constant(3, 2, 0, values);
     expr *log_node = new_log(const_node);
     expr *sum_node = new_sum(log_node, -1);
     sum_node->forward(sum_node, NULL);
@@ -44,7 +44,7 @@ const char *test_sum_axis_0()
        Stored as: [1, 2, 3, 4, 5, 6]
     */
     double values[6] = {1.0, 2.0, 3.0, 4.0, 5.0, 6.0};
-    expr *const_node = new_constant(3, 2, values);
+    expr *const_node = new_constant(3, 2, 0, values);
     expr *log_node = new_log(const_node);
     expr *sum_node = new_sum(log_node, 0);
     sum_node->forward(sum_node, NULL);
@@ -73,7 +73,7 @@ const char *test_sum_axis_1()
        Stored as: [1, 2, 3, 4, 5, 6]
     */
     double values[6] = {1.0, 2.0, 3.0, 4.0, 5.0, 6.0};
-    expr *const_node = new_constant(3, 2, values);
+    expr *const_node = new_constant(3, 2, 0, values);
     expr *log_node = new_log(const_node);
     expr *sum_node = new_sum(log_node, 1);
     sum_node->forward(sum_node, NULL);

tests/forward_pass/affine/test_variable_constant.h

@@ -21,7 +21,7 @@ const char *test_constant()
 {
     double c[2] = {5.0, 10.0};
     double u[2] = {0.0, 0.0};
-    expr *const_node = new_constant(2, 1, c);
+    expr *const_node = new_constant(2, 1, 0, c);
     const_node->forward(const_node, u);
     mu_assert("Constant test failed", cmp_double_array(const_node->value, c, 2));
     free_expr(const_node);

tests/forward_pass/composite/test_composite.h

@@ -16,7 +16,7 @@ const char *test_composite()
     /* Build tree: log(exp(x) + c) */
     expr *var = new_variable(2, 1, 0, 2);
     expr *exp_node = new_exp(var);
-    expr *const_node = new_constant(2, 1, c);
+    expr *const_node = new_constant(2, 1, 0, c);
     expr *sum = new_add(exp_node, const_node);
     expr *log_node = new_log(sum);
 

tests/utils/test_csr_matrix.h

@@ -217,7 +217,7 @@ const char *test_sum_all_rows_csr()
     memcpy(A->i, Ai, 7 * sizeof(int));
     memcpy(A->p, Ap, 4 * sizeof(int));
     CSR_Matrix *C = new_csr_matrix(1, 4, 4);
-    int_double_pair *pairs = new_int_double_pair_array(4);
+    int_double_pair *pairs = new_int_double_pair_array(7);
     sum_all_rows_csr(A, C, pairs);
     double Cx_correct[4] = {6.0, 5.0, 10.0, 7.0};
     int Ci_correct[4] = {0, 1, 2, 3};