we don't always have to run forward of parameter in left matmul

dance858 · dance858 · commit 5fc185f10bd2 · 2026-04-09T18:57:56.000-07:00
diff --git a/src/atoms/affine/left_matmul.c b/src/atoms/affine/left_matmul.c
@@ -67,7 +67,7 @@ static void forward(expr *node, const double *u)
     /* Always call forward on param_source if it exists */
     /* Should we also adopt a convention that left_matmul always
        points to a param_source, even if its constant? */
-    if (lnode->param_source != NULL)
+    if (lnode->param_source != NULL && lnode->base.needs_parameter_refresh)
     {
         lnode->param_source->forward(lnode->param_source, NULL);
     }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ static void forward(expr node, const double u)`
`67`	`67`	`/* Always call forward on param_source if it exists */`
`68`	`68`	`/* Should we also adopt a convention that left_matmul always`
`69`	`69`	`points to a param_source, even if its constant? */`
`70`		`- if (lnode->param_source != NULL)`
	`70`	`+ if (lnode->param_source != NULL && lnode->base.needs_parameter_refresh)`
`71`	`71`	`{`
`72`	`72`	`lnode->param_source->forward(lnode->param_source, NULL);`
`73`	`73`	`}`