Skip to content

Commit d0ed832

Browse files
committed
cleanup left matmul as well
1 parent 9153a88 commit d0ed832

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/atoms/affine/left_matmul.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,11 @@ static void forward(expr *node, const double *u)
6464
{
6565
left_matmul_expr *lnode = (left_matmul_expr *) node;
6666

67-
/* Refresh param_source expression tree if parameters changed.*/
68-
if (lnode->param_source != NULL && lnode->base.needs_parameter_refresh)
67+
/* Always call forward on param_source if it exists */
68+
/* Should we also adopt a convention that left_matmul always
69+
points to a param_source, even if its constant? */
70+
if (lnode->param_source != NULL)
6971
{
70-
/* pass NULL to forward: constant param_source never depends on u */
7172
lnode->param_source->forward(lnode->param_source, NULL);
7273
}
7374

0 commit comments

Comments
 (0)