We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 9153a88 commit d0ed832Copy full SHA for d0ed832
1 file changed
src/atoms/affine/left_matmul.c
@@ -64,10 +64,11 @@ static void forward(expr *node, const double *u)
64
{
65
left_matmul_expr *lnode = (left_matmul_expr *) node;
66
67
- /* Refresh param_source expression tree if parameters changed.*/
68
- if (lnode->param_source != NULL && lnode->base.needs_parameter_refresh)
+ /* Always call forward on param_source if it exists */
+ /* Should we also adopt a convention that left_matmul always
69
+ points to a param_source, even if its constant? */
70
+ if (lnode->param_source != NULL)
71
- /* pass NULL to forward: constant param_source never depends on u */
72
lnode->param_source->forward(lnode->param_source, NULL);
73
}
74
0 commit comments