Minor cleanup, removed property from demo entity

Author: pergerch

samples/SpatialFocus.EntityFrameworkCore.Extensions.SQLiteDemo/Entities/Product.cs

@@ -24,8 +24,6 @@ public Product()
 
 		public ProductCategory ProductCategory { get; set; }
 
-		public ProductCategory ProductCategorySecondField { get; set; }
-
 		public int ProductId { get; set; }
 
 		public DateTime ReleaseDate { get; set; }

src/SpatialFocus.EntityFrameworkCore.Extensions/EnumLookupExtension.cs

@@ -15,6 +15,8 @@ namespace SpatialFocus.EntityFrameworkCore.Extensions
 
 	public static class EnumLookupExtension
 	{
+		private static List<Type> ConcreteTypeSeededList { get; set; } = new List<Type>();
+
 		// See https://github.com/aspnet/EntityFrameworkCore/issues/12248#issuecomment-395450990
 		public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLookupOptions enumOptions)
 		{
@@ -43,8 +45,7 @@ public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLooku
 				string tableName = enumOptions.NamingFunction(typeName);
 				enumLookupBuilder.ToTable(tableName);
 
-				string keyName = enumOptions.UseNumberLookup
-					? nameof(EnumWithNumberLookup<Enum>.Id)
+				string keyName = enumOptions.UseNumberLookup ? nameof(EnumWithNumberLookup<Enum>.Id)
 					: nameof(EnumWithStringLookup<Enum>.Id);
 
 				modelBuilder.Entity(entityType.Name).HasOne(concreteType).WithMany().HasPrincipalKey(keyName).HasForeignKey(property.Name);
@@ -63,6 +64,13 @@ public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLooku
 					modelBuilder.Entity(concreteType).Property(keyName).HasConversion(valueConverter);
 				}
 
+				if (ConcreteTypeSeededList.Contains(concreteType))
+				{
+					continue;
+				}
+
+				ConcreteTypeSeededList.Add(concreteType);
+
 				// TODO: Check status of https://github.com/aspnet/EntityFrameworkCore/issues/12194 before using migrations
 				object[] data = Enum.GetValues(propertyType.GetEnumOrNullableEnumType())
 					.OfType<object>()
@@ -84,21 +92,10 @@ public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLooku
 					})
 					.ToArray();
 
-				if (!ConcreteTypeSeededList.Contains(concreteType))
-				{
-					ConcreteTypeSeededList.Add(concreteType);
-				}
-				else
-				{
-					continue;
-				}
-
 				enumLookupBuilder.HasData(data);
 			}
 		}
 
-		private static List<Type> ConcreteTypeSeededList { get; set; } = new List<Type>();
-
 		private static Type GetEnumOrNullableEnumType(this Type propertyType)
 		{
 			if (!propertyType.IsEnumOrNullableEnumType())
@@ -109,10 +106,8 @@ private static Type GetEnumOrNullableEnumType(this Type propertyType)
 			return propertyType.IsEnum ? propertyType : propertyType.GetGenericArguments()[0];
 		}
 
-
 		private static bool HasEnumWithAttribute(this Type propertyType)
 		{
-
 			if (propertyType.GetCustomAttributes(typeof(EnumLookupAttribute), true).Any())
 			{
 				return true;