Skip to content

Commit 3220ed5

Browse files
authored
BED-5152: Fix to filter out domains that are "."
1 parent 6c251ef commit 3220ed5

2 files changed

Lines changed: 27 additions & 1 deletion

File tree

src/CommonLib/Processors/ComputerSessionProcessor.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,11 @@ await SendComputerStatus(new CSVComputerStatus {
121121
username.Equals("anonymous logon", StringComparison.CurrentCultureIgnoreCase)) {
122122
continue;
123123
}
124+
125+
//Filter out domains that are "."
126+
if (computerDomain.Equals(".")) {
127+
continue;
128+
}
124129

125130
// Remove leading slashes for unc paths
126131
computerSessionName = computerSessionName.TrimStart('\\');
@@ -239,6 +244,11 @@ await SendComputerStatus(new CSVComputerStatus {
239244
if (string.IsNullOrWhiteSpace(username) || username.EndsWith("$", StringComparison.Ordinal)) {
240245
continue;
241246
}
247+
248+
//Filter out domains that are "."
249+
if (domain.Equals(".")) {
250+
continue;
251+
}
242252

243253
if (await _utils.ResolveAccountName(username, domain) is (true, var res)) {
244254
results.Add(res);

test/unit/ComputerSessionProcessorTest.cs

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,21 @@ public async Task ComputerSessionProcessor_ReadUserSessions_FilteringWorks() {
4949
Assert.True(result.Collected);
5050
Assert.Empty(result.Results);
5151
}
52+
53+
[Fact]
54+
public async Task ComputerSessionProcessor_ReadUserSessions_FilteringDomainWorks() {
55+
var mockNativeMethods = new Mock<NativeMethods>();
56+
57+
var apiResult = new NetSessionEnumResults[] {
58+
new("temp", "\\\\192.168.92.110")
59+
};
60+
mockNativeMethods.Setup(x => x.NetSessionEnum(It.IsAny<string>())).Returns(apiResult);
61+
62+
var processor = new ComputerSessionProcessor(new MockLdapUtils(), mockNativeMethods.Object,null, "dfm");
63+
var result = await processor.ReadUserSessions("win10", _computerSid, ".");
64+
Assert.True(result.Collected);
65+
Assert.Empty(result.Results);
66+
}
5267

5368
[Fact]
5469
public async Task ComputerSessionProcessor_ReadUserSessions_ResolvesHost() {
@@ -178,7 +193,8 @@ public async Task ComputerSessionProcessor_ReadUserSessionsPrivileged_FilteringW
178193
new("WIN10$", "TESTLAB"),
179194
new("JOHN", "WIN10"),
180195
new("SYSTEM", "NT AUTHORITY"),
181-
new("ABC", "TESTLAB")
196+
new("ABC", "TESTLAB"),
197+
new("XYZ", ".")
182198
};
183199
mockNativeMethods.Setup(x => x.NetWkstaUserEnum(It.IsAny<string>())).Returns(apiResults);
184200

0 commit comments

Comments
 (0)