Don't apply adaptive timeouts to LDAP queries (#252)

* fix: Don't apply adaptive timeouts to LDAP queries

* chore: Tuning Adaptive Timeout to be less aggressive overall

Author: definitelynotagoblin

src/CommonLib/AdaptiveTimeout.cs

@@ -20,10 +20,10 @@ public sealed class AdaptiveTimeout : IDisposable {
     private int _timeSpikeDecay;
     private const int TimeSpikePenalty = 2;
     private const int TimeSpikeForgiveness = 1;
-    private const int TimeSpikeThreshold = 5;
+    private const int TimeSpikeThreshold = 3;
     private const int ExcessiveTimeoutsThreshold = 7;
-    private const int StdDevMultiplier = 5;
-    private const int CountOfLatestSuccessToKeep = 4;
+    private const int StdDevMultiplier = 7; // 7 standard deviations should be a very conservative upper bound
+    private const int CountOfLatestSuccessToKeep = 3;
 
     public AdaptiveTimeout(TimeSpan maxTimeout, ILogger log, int sampleCount = 100, int logFrequency = 1000, int minSamplesForAdaptiveTimeout = 30, bool useAdaptiveTimeout = true, bool throwIfExcessiveTimeouts = false) {
         if (maxTimeout <= TimeSpan.Zero)

src/CommonLib/LdapConnectionPool.cs

@@ -58,9 +58,9 @@ public LdapConnectionPool(string identifier, string poolIdentifier, LdapConfig c
             _log = log ?? Logging.LogProvider.CreateLogger("LdapConnectionPool");
             _portScanner = scanner ?? new PortScanner();
             _nativeMethods = nativeMethods ?? new NativeMethods();
-            _queryAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapQuery"));
-            _pagedQueryAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapPagedQuery"));
-            _rangedRetrievalAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapRangedRetrieval"));
+            _queryAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapQuery"), useAdaptiveTimeout: false);
+            _pagedQueryAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapPagedQuery"), useAdaptiveTimeout: false);
+            _rangedRetrievalAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapRangedRetrieval"), useAdaptiveTimeout: false);
             _testConnectionAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("TestLdapConnection"));
         }