chore: coderabbit nits

Author: mykeelium

src/CommonLib/Ntlm/HttpNtlmAuthenticationService.cs

@@ -22,7 +22,7 @@ public class HttpNtlmAuthenticationService {
 
     public HttpNtlmAuthenticationService(INtlmHttpClientFactory ntlmHttpClientFactory, ILogger logger = null) {
         _logger = logger ?? Logging.LogProvider.CreateLogger(nameof(HttpNtlmAuthenticationService));
-        _ntlmHttpClientFactory = ntlmHttpClientFactory;
+        _ntlmHttpClientFactory = ntlmHttpClientFactory ?? throw new ArgumentNullException(nameof(ntlmHttpClientFactory));
         _getSupportedNTLMAuthSchemesAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger(nameof(GetSupportedNtlmAuthSchemesAsync)));
         _ntlmAuthAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger(nameof(NtlmAuthenticationHandler.PerformNtlmAuthenticationAsync)));
         _authWithChannelBindingAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger(nameof(AuthWithBadChannelBindingsAsync)));
@@ -206,4 +206,4 @@ public AuthNotRequiredException() {
 
     public AuthNotRequiredException(string message) : base(message) {
     }
-}
+}

src/CommonLib/Processors/CAEnrollmentProcessor.cs

@@ -19,8 +19,9 @@ public class CAEnrollmentProcessor {
         private readonly string _caName;
         private readonly ILogger _logger;
 
-        private const SslProtocols CaEnrollmentSslProtocols = 
-            SslProtocols.Ssl3 | SslProtocols.Tls | SslProtocols.Tls11 | SslProtocols.Tls12;
+        // TLS1.3 is not available in .Net Framework 4.7.2, but the enum can still be assigned.
+        private const SslProtocols CaEnrollmentSslProtocols =
+            SslProtocols.Ssl3 | SslProtocols.Tls | SslProtocols.Tls11 | SslProtocols.Tls12 | (SslProtocols)12288;
 
         public CAEnrollmentProcessor(string caDnsHostname, string caName, ILogger log = null) {
             _caDnsHostname = caDnsHostname;
@@ -46,7 +47,7 @@ await Task.WhenAll(
             } catch (Exception ex) {
                 _logger.LogError(ex, "An error occurred while scanning enrollment endpoints");
             }
-            
+
             endpoints = TagEndpoints(endpoints).ToList();
 
             return endpoints;
@@ -57,7 +58,7 @@ private IEnumerable<APIResult<CAEnrollmentEndpoint>> TagEndpoints(IEnumerable<AP
             foreach (var endpoint in tagEndpoints) {
                 if (!endpoint.Collected)
                     continue;
-                
+
                 var enrollmentEndpoint = endpoint.Result;
                 if (enrollmentEndpoint.Url.Scheme != Uri.UriSchemeHttps) {
                     switch (enrollmentEndpoint.Status) {
@@ -226,4 +227,4 @@ private async Task<APIResult<CAEnrollmentEndpoint>> GetNtlmEndpoint(Uri url, boo
             }
         }
     }
-}
+}