Skip to content

Commit a068ff6

Browse files
committed
chore: some sanity checks
1 parent 2c182fe commit a068ff6

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/CommonLib/LdapConnectionPool.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -811,17 +811,17 @@ public void ReleaseConnection(LdapConnectionWrapper connectionWrapper, bool conn
811811
}
812812
}
813813
else {
814-
connectionWrapper.Connection.Dispose();
814+
connectionWrapper.Connection?.Dispose();
815815
}
816816
}
817817

818818
public void Dispose() {
819819
while (_connections.TryTake(out var wrapper)) {
820-
wrapper.Connection.Dispose();
820+
wrapper.Connection?.Dispose();
821821
}
822822

823823
while (_globalCatalogConnection.TryTake(out var wrapper)) {
824-
wrapper.Connection.Dispose();
824+
wrapper.Connection?.Dispose();
825825
}
826826
}
827827

test/unit/LdapConnectionPoolTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ private static ConcurrentBag<LdapConnectionWrapper> GetConnectionsBag(LdapConnec
2323
.GetField("_connections", BindingFlags.Instance | BindingFlags.NonPublic);
2424
return (ConcurrentBag<LdapConnectionWrapper>)field.GetValue(pool);
2525
}
26-
26+
2727
private static ConcurrentBag<LdapConnectionWrapper> GetGlobalCatalogConnectionsBag(LdapConnectionPool pool) {
2828
var field = typeof(LdapConnectionPool)
2929
.GetField("_globalCatalogConnection", BindingFlags.Instance | BindingFlags.NonPublic);

0 commit comments

Comments
 (0)