fix: add adaptive timeouts to missing portions of enumeration (#261)

* fix: add adaptive timeouts to missing portions of enumeration

* chore: add a comment about these nested result objects

* fix: return a APIResult

Author: rvazarkar

src/CommonLib/IRegistryKey.cs

@@ -39,8 +39,7 @@ public static async Task<SHRegistryKey> Connect(RegistryHive hive, string machin
             var remoteKey = await _adaptiveTimeout.ExecuteWithTimeout((_) => RegistryKey.OpenRemoteBaseKey(hive, machineName));
             if (remoteKey.IsSuccess)
                 return new SHRegistryKey(remoteKey.Value);
-            else
-                throw new TimeoutException($"Failed to connect to registry on {machineName}: {remoteKey.Error}");
+            throw new TimeoutException($"Failed to connect to registry on {machineName}: {remoteKey.Error}");
         }
 
         public void Dispose() {

src/CommonLib/Processors/RegistryProcessor.cs

@@ -15,6 +15,7 @@ public class RegistryProcessor {
     private readonly IPortScanner _portScanner;
     private readonly ICollectionStrategy<RegistryQueryResult, RegistryQuery>[] _strategies;
     private readonly RegistryQuery[] _queries;
+    private readonly AdaptiveTimeout _registryAdaptiveTimeout = new(maxTimeout:TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger(nameof(ReadRegistrySettings)));
 
     public RegistryProcessor(ILogger log, string domain) {
         _log = log ?? Logging.LogProvider.CreateLogger("RegistryProcessor");
@@ -54,9 +55,15 @@ public async Task<APIResult<RegistryData>> ReadRegistrySettings(string targetMac
 
         try {
             var registryCollector = new StrategyExecutor();
-            var collectedData = await registryCollector
+            var result = await _registryAdaptiveTimeout.ExecuteWithTimeout(async (_) => await registryCollector
                 .CollectAsync(targetMachine, _queries, _strategies)
-                .ConfigureAwait(false);
+                .ConfigureAwait(false));
+
+            if (!result.IsSuccess) {
+                return APIResult<RegistryData>.Failure($"Timeout when grabbing registry data from {targetMachine}");
+            }
+
+            var collectedData = result.Value;
 
             foreach (var key in collectedData.Results ?? []) {
                 if (!key.ValueExists)

src/CommonLib/Processors/WebClientServiceProcessor.cs

@@ -16,6 +16,7 @@ namespace SharpHoundCommonLib.Processors {
     /// <param name="log"></param>
     public class WebClientServiceProcessor(ILogger log = null) {
         private readonly ILogger _log = log ?? Logging.LogProvider.CreateLogger("WebClientServiceProcessor");
+        private readonly AdaptiveTimeout _createFileAdaptiveTimeout = new(maxTimeout:TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger(nameof(IsWebClientRunning)));
 
         // Define constants
         public const uint MAXIMUM_ALLOWED = 0x02000000;
@@ -78,15 +79,21 @@ public async Task<APIResult<bool>> IsWebClientRunning(string computerName) {
             // When the service is running, this named pipe is present
             var pipePath = @$"\\{computerName}\pipe\DAV RPC SERVICE";
 
-            return await Task.Run(() => {
+            var result = await _createFileAdaptiveTimeout.ExecuteWithTimeout((_) => {
                 try {
                     var exists = TestPathExists(pipePath);
-
                     return APIResult<bool>.Success(exists);
                 } catch (Exception ex) {
                     return APIResult<bool>.Failure(ex.ToString());
                 }
             });
+
+            //TODO: Not a big fan of nested result objects. We should look at this later to see if we can simplify the interface
+            if (result.IsSuccess) {
+                return result.Value;
+            }
+            
+            return APIResult<bool>.Failure($"Failed to check pipe on {computerName} due to timeout: {pipePath}");
         }
     }
 }