Skip to content

Commit c7bf98c

Browse files
authored
fix AntiXssLibrary missing dependency (#283)
1 parent 8b55f93 commit c7bf98c

4 files changed

Lines changed: 9 additions & 3 deletions

File tree

RPCTest/RPCTest.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
<LangVersion>latest</LangVersion>
66
<ImplicitUsings>enable</ImplicitUsings>
77
<Nullable>enable</Nullable>
8+
<!-- Suppress cross-targeting warning when referencing net472 projects in net8.0 tests -->
9+
<NoWarn>$(NoWarn);NU1702</NoWarn>
810
</PropertyGroup>
911

1012
<ItemGroup>

src/CommonLib/SharpHoundCommonLib.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<DebugType>full</DebugType>
1919
</PropertyGroup>
2020
<ItemGroup>
21-
<PackageReference Include="AntiXSS" Version="4.3.0" PrivateAssets="All"/>
21+
<PackageReference Include="AntiXSS" Version="4.3.0" />
2222
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
2323
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
2424
</ItemGroup>

test/unit/CommonLibTest.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
<CollectCoverage>true</CollectCoverage>
77
<CoverletOutput>..\..\docfx\coverage\</CoverletOutput>
88
<CoverletOutputFormat>OpenCover</CoverletOutputFormat>
9-
<!-- Suppress cross-targeting warning when referencing net472 SharpHound projects in net8.0 tests -->
10-
<NoWarn>$(NoWarn);NU1702</NoWarn>
9+
<!-- Suppress cross-targeting warning when referencing net472 projects/packages in net8.0 tests -->
10+
<NoWarn>$(NoWarn);NU1702;NU1701</NoWarn>
1111
</PropertyGroup>
1212

1313
<!-- Project references -->

test/unit/RegistryProcessorTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
using System;
22
using System.Collections.Generic;
33
using System.Linq;
4+
using System.Runtime.Versioning;
45
using System.Threading.Tasks;
56
using CommonLibTest.Facades;
67
using Microsoft.Extensions.Logging;
@@ -74,6 +75,7 @@ public async Task RegistryProcessor_ReadRegistrySettings_CollectionFailed() {
7475
}
7576
}
7677

78+
[SupportedOSPlatform("windows")]
7779
[WindowsOnlyFact]
7880
public async Task RegistryProcessor_ReadRegistrySettings_FirstStrategySuccessful() {
7981
const uint minClientSecValue = 536870912;
@@ -106,6 +108,7 @@ public async Task RegistryProcessor_ReadRegistrySettings_FirstStrategySuccessful
106108
VerifyCompStatusLog(task, TargetName, CSVComputerStatus.StatusSuccess);
107109
}
108110

111+
[SupportedOSPlatform("windows")]
109112
[WindowsOnlyFact]
110113
public async Task RegistryProcessor_ReadRegistrySettings_SecondStrategySuccessful() {
111114
const string failureReason = "No such host is known.";
@@ -166,6 +169,7 @@ public async Task RegistryProcessor_ReadRegistrySettings_HandlesException() {
166169
Assert.Empty(_receivedCompStatuses);
167170
}
168171

172+
[SupportedOSPlatform("windows")]
169173
[WindowsOnlyFact]
170174
public async Task RegistryProcessor_ReadRegistrySettings_SetsAllValues() {
171175
var allowedServers = new[] {"server"};

0 commit comments

Comments
 (0)