[BED-6067] Add isReadOnlyDC property to computer objects (#218)

* feat: Add isReadOnlyDC property to computer objects

* fix: remove IsReadOnlyDC from computer output type

Author: definitelynotagoblin

src/CommonLib/Processors/LdapPropertyProcessor.cs

@@ -356,6 +356,7 @@ public async Task<ComputerProperties> ReadComputerProperties(IDirectoryObject en
             props.Add("unconstraineddelegation", flags.HasFlag(UacFlags.TrustedForDelegation));
             props.Add("trustedtoauth", flags.HasFlag(UacFlags.TrustedToAuthForDelegation));
             props.Add("isdc", flags.HasFlag(UacFlags.ServerTrustAccount));
+            props.Add("isreadonlydc", flags.HasFlag(UacFlags.PartialSecretsAccount));
             props.Add("encryptedtextpwdallowed", flags.HasFlag(UacFlags.EncryptedTextPwdAllowed));
             props.Add("usedeskeyonly", flags.HasFlag(UacFlags.UseDesKeyOnly));
             props.Add("logonscriptenabled", flags.HasFlag(UacFlags.Script));

test/unit/LdapPropertyTests.cs

@@ -464,13 +464,15 @@ public async Task LDAPPropertyProcessor_ReadComputerProperties_HappyPath()
             Assert.Contains("unconstraineddelegation", keys);
             Assert.Contains("trustedtoauth", keys);
             Assert.Contains("isdc", keys);
+            Assert.Contains("isreadonlydc", keys);
             Assert.Contains("lastlogon", keys);
             Assert.Contains("lastlogontimestamp", keys);
             Assert.Contains("pwdlastset", keys);
             Assert.True((bool)props["enabled"]);
             Assert.False((bool)props["unconstraineddelegation"]);
             Assert.True((bool)props["trustedtoauth"]);
             Assert.False((bool)props["isdc"]);
+            Assert.False((bool)props["isreadonlydc"]);
 
             Assert.Contains("lastlogon", keys);
             Assert.Equal(1622827514, (long)props["lastlogon"]);