Skip to content

Commit f5f191a

Browse files
authored
Check if ResolveAccountName returns a value (#90)
1 parent 00c2180 commit f5f191a

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

src/CommonLib/Processors/GPOLocalGroupProcessor.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -531,6 +531,11 @@ internal IEnumerable<GroupAction> ProcessGPOXmlFile(string basePath, string gpoD
531531
var domain = s[0];
532532

533533
var res = _utils.ResolveAccountName(name, domain);
534+
if (res == null)
535+
{
536+
_log.LogWarning("Failed to resolve member {memberName}", memberName);
537+
continue;
538+
}
534539
ga.Target = GroupActionTarget.LocalGroup;
535540
ga.TargetSid = res.ObjectIdentifier;
536541
ga.TargetType = res.ObjectType;
@@ -540,6 +545,11 @@ internal IEnumerable<GroupAction> ProcessGPOXmlFile(string basePath, string gpoD
540545
else
541546
{
542547
var res = _utils.ResolveAccountName(memberName, gpoDomain);
548+
if (res == null)
549+
{
550+
_log.LogWarning("Failed to resolve member {memberName}", memberName);
551+
continue;
552+
}
543553
ga.Target = GroupActionTarget.LocalGroup;
544554
ga.TargetSid = res.ObjectIdentifier;
545555
ga.TargetType = res.ObjectType;

0 commit comments

Comments
 (0)