Merge pull request #2 from SpecterOps/2024-q2-updates

chore: minor improvements

Author: sircodemane

.gitignore

@@ -1,2 +1,4 @@
+.vscode
+.idea
 .DS_Store
 

README.md

@@ -2,9 +2,19 @@
 
 ## The Sieve of Eratosthenes
 
-Prime numbers have many modern day applications and a long history in mathematics. Utilizing your own resources research the sieve of Eratosthenes, an algorithm for generating prime numbers. Based on your research, implement an API that allows the caller to retrieve the Nth prime number.
-Some stub code and a test suite have been provided as a convenience, however, you are encouraged to deviate from Eratosthenes's algorithm, modify the existing functions/methods or anything else that might showcase your ability provided the following requirements are satisfied.
-Stub code has been provided in Go, C#, and Javascript. Please use the language that is most appropriate based on your own skillset
+Prime numbers have many modern day applications and a long history in 
+mathematics. Utilizing your own resources research the sieve of Eratosthenes,
+an algorithm for generating prime numbers. Based on your research, implement 
+an API that allows the caller to retrieve the Nth prime number.
+Some stub code and a test suite have been provided as a convenience, however, 
+you are encouraged to deviate from Eratosthenes's algorithm, modify the 
+existing functions/methods or anything else that might showcase your ability 
+provided the following requirements are satisfied.
+
+You must author your work in either Go, JavaScript/TypeScript, or C# - all 
+other language submissions will be rejected. Stub code has been provided so 
+please choose from one of the provided language stubs that is most 
+appropriate based on your own skill set and the position you are applying for.
 
 ### Requirements
 
@@ -19,6 +29,9 @@ Stub code has been provided in Go, C#, and Javascript. Please use the language t
 
 ### Considerations
 
+You may add more tests or restructure tests, but you may NOT change or remove
+the existing test outcomes; eg- f(0)=2, f(19)=71, f(99)=541, ..., f(10000000)=179424691 
+
 During the technical interview, your submission will be discussed, and you will be evaluated in the following areas:
 
 - Technical ability

csharp/Sieve.Tests/UnitTest1.cs

@@ -15,6 +15,8 @@ public void TestNthPrime()
             Assert.AreEqual(7793, sieve.NthPrime(986));
             Assert.AreEqual(17393, sieve.NthPrime(2000));
             Assert.AreEqual(15485867, sieve.NthPrime(1000000));
+            Assert.AreEqual(179424691, sieve.NthPrime(10000000));
+            //Assert.AreEqual(2038074751, sieve.NthPrime(100000000));
         }
     }
 }

go/pkg/sieve/sieve_test.go

@@ -10,13 +10,15 @@ import (
 func TestNthPrime(t *testing.T) {
 	sieve := NewSieve()
 
-	assert.Equal(t, 2, sieve.NthPrime(0))
-	assert.Equal(t, 71, sieve.NthPrime(19))
-	assert.Equal(t, 541, sieve.NthPrime(99))
-	assert.Equal(t, 3581, sieve.NthPrime(500))
-	assert.Equal(t, 7793, sieve.NthPrime(986))
-	assert.Equal(t, 17393, sieve.NthPrime(2000))
-	assert.Equal(t, 15485867, sieve.NthPrime(1000000))
+	assert.Equal(t, int64(2), sieve.NthPrime(0))
+	assert.Equal(t, int64(71), sieve.NthPrime(19))
+	assert.Equal(t, int64(541), sieve.NthPrime(99))
+	assert.Equal(t, int64(3581), sieve.NthPrime(500))
+	assert.Equal(t, int64(7793), sieve.NthPrime(986))
+	assert.Equal(t, int64(17393), sieve.NthPrime(2000))
+	assert.Equal(t, int64(15485867), sieve.NthPrime(1000000))
+	assert.Equal(t, int64(179424691), sieve.NthPrime(10000000))
+	//assert.Equal(t, int64(2038074751), sieve.NthPrime(100000000))
 }
 
 func FuzzNthPrime(f *testing.F) {

javascript/Sieve/sieve.test.js

@@ -10,5 +10,7 @@ describe("Sieve", () => {
     expect(sieve.NthPrime(986)).toBe(7793);
     expect(sieve.NthPrime(2000)).toBe(17393);
     expect(sieve.NthPrime(1000000)).toBe(15485867);
+    expect(sieve.NthPrime(10000000)).toBe(179424691);
+    //expect(sieve.NthPrime(100000000)).toBe(2038074751);
   });
 });