- Pointless refactorization

- Finally time to switch over to stringbuilder
- Fixed Spectral's dialogue
- Probably fixed some other stuff, I can't remember

Author: SpectralPlatypus

DebugHUD.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Reflection;
+using System.Text;
 using TMPro;
 using UnityEngine;
 using UnityEngine.SceneManagement;
@@ -25,28 +26,31 @@ public NPCCache(string npc, TextAsset asset)
 
         static GameObject OverlayCanvas = null;
         static GameObject _textPanel;
+        static TextMeshProUGUI textComp;
         static CanvasUtil.RectData topRight = new CanvasUtil.RectData(new Vector2(0, 0), new Vector2(0, 0),
                     new Vector2(0.89f, 0.80f), new Vector2(0.99f, .96f), new Vector2(0, 0));
 
         PlayerMachine PlayerMachine = null;
         BossController bossController = null;
-        bool _enabled = false;
+
 
         // Cached objects
         List<NPCCache> dialogueCache = new List<NPCCache>(10);
         GameObjectCache<VoidOut> collPlaneCache = new GameObjectCache<VoidOut>();
         GameObjectCache<TalkVolume> tvRadiusCache = new GameObjectCache<TalkVolume>();
         Dictionary<string, Texture2D> modTextures = new Dictionary<string, Texture2D>(2);
+        StringBuilder textBuilder = new StringBuilder(500);
 
         // Warp cam related
         Camera warpCam = null;
+        Vector3 warpSimPos = Vector3.zero;
         float yaw = 0f;
         float pitch = 0f;
 
         // Noclip mode
         LayerMask origMask;
         float origGrav;
-        public static bool NoClipActive = false;
+        public static bool NoClipActive { get; private set; } = false;
 
         // UI constants
         static readonly string[] costumeNames = { "Noid", "Green", "Sanic", "Cappy" };
@@ -58,11 +62,13 @@ public NPCCache(string npc, TextAsset asset)
         int currentNpcIdx = 0;
         int currentLvlIdx = 0;
         float deltaTime = 0f;
+
+        bool _enabled = false;
         bool _visible = false;
+
         bool deathPlaneStatus = true;
         bool collisionRenderFlag = false;
         bool talkVolumeRenderFlag = false;
-        Vector3 warpSimPos = new Vector3(0f, 0f, 0f);
 
         public void Awake()
         {
@@ -78,6 +84,7 @@ public void Awake()
                 _textPanel = CanvasUtil.CreateTMProPanel(_background, string.Empty, 20,
                     TextAnchor.UpperLeft,
                     new CanvasUtil.RectData(new Vector2(-5, -5), new Vector2(0, 0), new Vector2(0, 0), new Vector2(1, 1)));
+                textComp = _textPanel.GetComponent<TextMeshProUGUI>();
             }
 
             foreach (string fn in Assembly.GetExecutingAssembly().GetManifestResourceNames())
@@ -247,18 +254,20 @@ private void SetupNoClip(bool toggle)
 
         }
 
+        string OnOffStr(bool val) => val ? "ON" : "OFF";
+
         public void Update()
         {
             if (Input.GetKeyDown(KeyCode.F11))
             {
                 _visible = !_visible;
+                var cg = OverlayCanvas.GetComponent<CanvasGroup>();
                 StartCoroutine(_visible
-                    ? CanvasUtil.FadeInCanvasGroup(OverlayCanvas.GetComponent<CanvasGroup>())
-                    : CanvasUtil.FadeOutCanvasGroup(OverlayCanvas.GetComponent<CanvasGroup>()));
+                    ? CanvasUtil.FadeInCanvasGroup(cg)
+                    : CanvasUtil.FadeOutCanvasGroup(cg));
             }
 
-            var t = _textPanel.GetComponent<TextMeshProUGUI>();
-            t.text = "";
+            textComp.text = "";
 
             if (!_enabled || !_visible || PlayerMachine == null)
             {
@@ -319,14 +328,8 @@ public void Update()
 
             if (Input.GetKeyDown(KeyCode.F6) || Input.GetKeyDown(KeyCode.Keypad6))
             {
-                if (QualitySettings.vSyncCount == 2)
-                {
-                    QualitySettings.vSyncCount = 0;
-                }
-                else
-                {
-                    QualitySettings.vSyncCount++;
-                }
+                ++QualitySettings.vSyncCount;
+                QualitySettings.vSyncCount %= 3;
             }
 
             bool inVoid = SceneManager.GetActiveScene().name == "void";
@@ -335,7 +338,7 @@ public void Update()
                 var pizza = FindObjectOfType<PizzaBox>();
                 if (pizza == null)
                 {
-                    Logger.LogDebug("No PizzaBox!");
+                    Logger.LogError("No PizzaBox!");
                 }
                 else
                 {
@@ -344,15 +347,15 @@ public void Update()
                     GameObject.Find("Global Manager").GetComponent<Manager>().LoadScene(level, pizza.ExitId, pizza.gameObject);
                 }
             }
-            else if (Input.GetKeyDown(KeyCode.L))
+            else if (inVoid && Input.GetKeyDown(KeyCode.L))
             {
                 do
                 {
                     currentLvlIdx = (currentLvlIdx + 1) % levelNames.Length;
                 } while (levelNames[currentLvlIdx] == SceneManager.GetActiveScene().name);
             }
 
-            if (Input.GetKeyDown(KeyCode.K))
+            if (!inVoid && Input.GetKeyDown(KeyCode.K))
             {
                 var key = FindObjectsOfType<Key>();
                 foreach (var k in key)
@@ -451,7 +454,7 @@ public void Update()
                 }
             }
 
-            if (Input.GetKeyDown(KeyCode.F8))
+            if (Input.GetKeyDown(KeyCode.F8) || Input.GetKeyDown(KeyCode.Keypad8))
             {
                 foreach (var e in FindObjectsOfType<HiddenPlatform>())
                 {
@@ -462,43 +465,50 @@ public void Update()
             deltaTime += (Time.unscaledDeltaTime - deltaTime) * 0.1f;
             bool? b = PlayerMachine.CoyoteFrameEnabled;
 
-            t.text += "FPS: " + 1f / deltaTime + "\n";
-            t.text += "<F1>: Coyote Frames: " + (b.HasValue ? (b.Value ? "ON" : "OFF") : "Default") + "\n";
-            t.text += "<F2><[]>: Set Costume: " + costumeNames[currentCostIdx] + "\n";
-            if (dialogueCache.Count > 0) t.text += "<F3><,.>: Dialogue: " + dialogueCache[currentNpcIdx].NpcName + "\n";
-            t.text += "<F4>: Time Scale: x" + Time.timeScale.ToString("F2") + "\n";
-            t.text += "<F5>: Text Storage/Warp\n";
-            t.text += "<F6>: VSync Count :" + QualitySettings.vSyncCount + "\n";
-            t.text += "<F7><L>: Level Load: " + (!inVoid ? "void" : levelNames[currentLvlIdx]) + "\n";
-            t.text += "<F8>: Reset Camera Events\n";
-            t.text += "<K>: Get All Keys\n";
-            t.text += "<V>: Render Death Planes: " + (collisionRenderFlag ? "ON" : "OFF") + "\n";
-            t.text += "<M>: Active Death Planes: " + (deathPlaneStatus ? "ON" : "OFF") + "\n";
-            t.text += "<G>: Show NPC Talk Zone: " + (talkVolumeRenderFlag ? "ON" : "OFF") + "\n";
-            t.text += "<R><noparse><B></noparse>: Warp Cam Move/Toggle \n";
-            t.text += "<N>: Set Obj Transparent\n";
-            t.text += "<T>: NoClip: " + (NoClipActive ? "ON" : "OFF") + "\n";
-            t.text += "<F11> Toggle UI\n\n";
-            t.text += "Move Dir:" + PlayerMachine.moveDirection.ToString() + "\n";
-            t.text += "Pos:" + PlayerMachine.transform.position + "\n";
-            t.text += "SpawnPos:" + PlayerMachine.LastGroundLoc.ToString() + "\n";
-            t.text += "Look Dir:" + PlayerMachine.lookDirection.ToString() + "\n";
-            t.text += "Player State:" + PlayerMachine.currentState.ToString() + "\n";
+            textBuilder.Length = 0;
+            textBuilder.AppendFormat("FPS: {0:F3}\n", 1f / deltaTime);
+            textBuilder.AppendFormat("<F1>: Coyote Frames: {0}\n", b.HasValue ? OnOffStr(b.Value) : "Default");
+            textBuilder.Append("<F2><[]>: Set Costume: ").AppendLine(costumeNames[currentCostIdx]);
+            textBuilder.AppendFormat("<F3><,.>: Dialogue: ").AppendLine(dialogueCache[currentNpcIdx].NpcName);
+            textBuilder.Append("<F4>: Time Scale: x").AppendLine(Time.timeScale.ToString("F2"));
+            textBuilder.Append("<F5>: Text Storage/Warp\n");
+            textBuilder.AppendFormat("<F6>: VSync Count :{0}\n", QualitySettings.vSyncCount);
+            textBuilder.AppendFormat("<F7><L>: Level Load: {0}\n", !inVoid ? "void" : levelNames[currentLvlIdx]);
+            textBuilder.Append("<F8>: Reset Camera Events\n");
+            textBuilder.Append("<K>: Get All Keys\n");
+            textBuilder.Append("<V>: Render Death Planes: ").AppendLine(OnOffStr(collisionRenderFlag));
+            textBuilder.Append("<M>: Active Death Planes: ").AppendLine(OnOffStr(deathPlaneStatus));
+            textBuilder.Append("<G>: Show NPC Talk Zone: ").AppendLine(OnOffStr(talkVolumeRenderFlag));
+            textBuilder.Append("<R><noparse><B></noparse>: Warp Cam Move/Toggle\n");
+            textBuilder.Append("<N>: Set Obj Transparent\n");
+            textBuilder.Append("<T>: NoClip: ").AppendLine(OnOffStr(NoClipActive));
+            textBuilder.Append("<F11> Toggle UI\n").AppendLine();
+
+            textBuilder.Append("Move Dir:").AppendLine(PlayerMachine.moveDirection.ToString());
+            textBuilder.Append("Pos:").AppendLine(PlayerMachine.transform.position.ToString());
+            textBuilder.Append("SpawnPos:").AppendLine(PlayerMachine.LastGroundLoc.ToString());
+            textBuilder.Append("Look Dir:").AppendLine(PlayerMachine.lookDirection.ToString());
+            textBuilder.Append("Player State:").AppendLine(PlayerMachine.currentState.ToString());
 
             if (bossController)
             {
-                t.text += "\nBoss Health: " + bossController.Health + "\n";
-                t.text += "Boss State: " + bossStates[(int)BossController.State] + "\n";
+                textBuilder.AppendLine();
+                textBuilder.Append("Boss Health: ").AppendLine(bossController.Health.ToString());
+                textBuilder.Append("Boss State: ").AppendLine(bossStates[(int)BossController.State]);
             }
             if (warpCam.enabled)
             {
-                t.text += "\nLGP:" + PlayerMachine.controller.LastGroundPos.ToString() + "\n";
-                t.text += "LGO:" + PlayerMachine.controller.LastGroundOffset.ToString() + "\n";
-                t.text += "LGR:" + PlayerMachine.controller.LastGroundRot.ToString() + "\n";
-                t.text += "CG:" + PlayerMachine.controller.currentGround.transform.position.ToString() + "\n";
-                t.text += "CR:" + PlayerMachine.controller.currentGround.transform.rotation.ToString() + "\n";
-                t.text += "Warp Pos:" + warpSimPos.ToString() + "\n";
+                textBuilder.AppendLine();
+                textBuilder.Append("LGP:").AppendLine(PlayerMachine.controller.LastGroundPos.ToString());
+                textBuilder.Append("LGO:").AppendLine(PlayerMachine.controller.LastGroundOffset.ToString());
+                textBuilder.Append("LGR:").AppendLine(PlayerMachine.controller.LastGroundRot.ToString());
+                textBuilder.Append("CG:").AppendLine(PlayerMachine.controller.currentGround.transform.position.ToString());
+                textBuilder.Append("CR:").AppendLine(PlayerMachine.controller.currentGround.transform.rotation.ToString());
+                textBuilder.Append("Warp Pos:").AppendLine(warpSimPos.ToString());
+
             }
+
+            textComp.SetText(textBuilder);
         }
     }
 }

DebugMod.cs

@@ -6,7 +6,7 @@ namespace DebugMod
 {
     public class DebugMod : Mod
     {
-        private const string _modVersion = "7.8";
+        private const string _modVersion = "8.0";
         private DebugHUD counter = null;
         private static GameObject go = null;
         private readonly Vector3 npcPos = new Vector3(926f, 44f, 364.7f);
@@ -25,7 +25,7 @@ public override void Initialize()
 
             go = new GameObject();
             counter = go.AddComponent<DebugHUD>();
-            UnityEngine.Object.DontDestroyOnLoad(go);
+            Object.DontDestroyOnLoad(go);
         }
 
         //For noclip fun
@@ -73,6 +73,7 @@ private void OnSceneChange(Scene oldScene, Scene newScene)
                 foreach (var npc in npcs)
                 {
                     var textAsset = npc.GetComponentInChildren<TalkVolume>().Dialogue;
+                    LogDebug(DialogueUtils.GetNPCName(textAsset.text));
                     if (DialogueUtils.GetNPCName(textAsset.text) == "Oleia")
                     {
                         spectralNpc = npc;
@@ -104,7 +105,7 @@ private string Instance_OnParseScriptHook(string text)
                     {
                         output =
                             "%n10%v0%\r\nSpectral\r\n" +
-                            "%m1%Run %m0%%s.5%%sD%%p15%%e1%%e2%All%p10%%m1% NPCs!\r\n\r\n%n\r\n";
+                            "%m1%Run%p11% %m0%%s.1%A%p8%l%p9%l %p10%%m1%N%p15%P%p16%Cs%p17%%sD%%p10%!\r\n\r\n%n\r\n";
                     }
                     break;
                 case "Denise":