Merge pull request #3833 from h-mayorquin/add_del_method_to_binary

Add del dunder to binary recording

Author: alejoe91

src/spikeinterface/core/binaryrecordingextractor.py

@@ -148,6 +148,18 @@ def get_binary_description(self):
         )
         return d
 
+    def __del__(self):
+        """
+        Ensures that all segment resources are properly cleaned up when this recording extractor is deleted.
+        Closes any open file handles in the recording segments.
+        """
+        # Close all recording segments
+        if hasattr(self, "_recording_segments"):
+            for segment in self._recording_segments:
+                # This will trigger the __del__ method of the BinaryRecordingSegment
+                # which will close the file handle
+                del segment
+
 
 BinaryRecordingExtractor.write_recording.__doc__ = BinaryRecordingExtractor.write_recording.__doc__.format(
     _shared_job_kwargs_doc
@@ -223,6 +235,15 @@ def get_traces(
 
         return traces
 
+    def __del__(self):
+        # Ensure that the file handle is closed when the segment is garbage-collected
+        try:
+            if hasattr(self, "file") and self.file and not self.file.closed:
+                self.file.close()
+        except Exception as e:
+            warnings.warn(f"Error closing file handle in BinaryRecordingSegment: {e}")
+            pass
+
 
 # For backward compatibility (old good time)
 BinDatRecordingExtractor = BinaryRecordingExtractor

src/spikeinterface/preprocessing/preprocessinglist.py

@@ -25,6 +25,7 @@
     CenterRecording,
     center,
 )
+
 from .scale import scale_to_uV
 
 from .whiten import WhitenRecording, whiten, compute_whitening_matrix