fix: Apply code review suggestions

- Fix yargs v18 migration by adding .argv to complete the builder chain
- Downgrade Jest from alpha (^30.0.0-alpha.6) to stable version (^29.7.0)
- Remove body-parser dependency and use Express 5.x built-in middleware
  - Replace bodyParser.json() with express.json()
  - Replace bodyParser.urlencoded() with express.urlencoded()
  - Remove body-parser from scaffoldTpl/package.json

Co-authored-by: maximizeIT <8626039+maximizeIT@users.noreply.github.com>

Author: Copilot

csss.js

@@ -24,15 +24,17 @@ const yargv = yargs(process.argv.slice(2))
   .string("name")
   .describe("name", "a specific package.json name of your app")
   .version("0.0.1")
-  .help("help").epilogue(`for more information,\please see the README at:
-    https://github.com/Staffbase/create-staffbase-plugin-nodejs/blob/main/README.MD`);
-// console.log('YARGS Parsed Data:\n', yargv.argv);
+  .help("help")
+  .epilogue(`for more information,\please see the README at:
+    https://github.com/Staffbase/create-staffbase-plugin-nodejs/blob/main/README.MD`)
+  .argv;
+// console.log('YARGS Parsed Data:\n', yargv);
 const packageJSON = fs.readJSONSync(path.join(scaffoldFolder, "package.json"));
 // Defaults package name to current folder name
-const nameParam = yargv.argv.N || yargv.argv.name || defaultNPMName;
+const nameParam = yargv.N || yargv.name || defaultNPMName;
 prompt.override = {
-  name: yargv.argv.N,
-  path: yargv.argv._[0],
+  name: yargv.N,
+  path: yargv._[0],
 };
 /**
  * Prompts user for just the npm name value.

package.json

@@ -42,7 +42,7 @@
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "highlight.js": "^11.11.1",
     "husky": "^9.1.7",
-    "jest": "^30.0.0-alpha.6",
+    "jest": "^29.7.0",
     "markdown-it": "^12.3.2",
     "marked": "^4.0.10",
     "typescript": "^5.9.3"

scaffoldTpl/app.js

@@ -3,7 +3,6 @@ let path = require("path");
 let favicon = require("serve-favicon");
 let logger = require("morgan");
 let cookieParser = require("cookie-parser");
-let bodyParser = require("body-parser");
 
 let index = require("./routes/index");
 let users = require("./routes/users");
@@ -25,8 +24,8 @@ app.set("view engine", "pug");
 // uncomment after placing your favicon in /public
 // app.use(favicon(path.join(__dirname, 'public', 'favicon.ico')));
 app.use(logger("dev"));
-app.use(bodyParser.json());
-app.use(bodyParser.urlencoded({ extended: false }));
+app.use(express.json());
+app.use(express.urlencoded({ extended: false }));
 app.use(cookieParser());
 app.use(express.static(path.join(__dirname, "public")));
 

scaffoldTpl/package.json

@@ -7,7 +7,6 @@
   },
   "dependencies": {
     "@staffbase/staffbase-plugin-sdk": "^1.3.1",
-    "body-parser": "^2.2.1",
     "cookie-parser": "^1.4.7",
     "debug": "^4.4.3",
     "express": "^5.2.1",