refactor: fix phpstan level 0

Author: Ninerian

test/PluginSessionTest.php

@@ -28,23 +28,20 @@
 
 class PluginSessionTest extends TestCase
 {
-    private $token;
-    private $publicKey;
-    private $privateKey;
-    private $tokenData;
-    private $classname = PluginSession::class;
-    private $pluginId = 'testplugin';
-    private $pluginInstanceId;
+    private string $token;
+    private string $publicKey;
+    private string $privateKey;
+    private array $tokenData;
+    private string $classname = PluginSession::class;
+    private string $pluginId = 'testplugin';
+    private string $pluginInstanceId;
 
     /**
-     * Constructor
-     *
      * Create an RSA-256 key pair, and set up initial token.
      */
-    public function __construct()
+    public function setUp(): void
     {
 
-        parent::__construct();
         $rsa = new RSA();
         $keypair = $rsa->createKey(2048);
 
@@ -57,6 +54,14 @@ public function __construct()
         $this->pluginInstanceId = $this->tokenData[SSODataClaimsInterface::CLAIM_INSTANCE_ID];
     }
 
+
+    public function tearDown(): void
+    {
+        session_write_close();
+        session_abort();
+        $_SESSION = [];
+    }
+
     /**
      * Setup the environment for PluginSession.
      *
@@ -88,7 +93,7 @@ private function setupEnvironment(string $queryParamPid = null, string $queryPar
     public function testConstructorWorksAsExpected()
     {
 
-        $this->setupEnvironment(null, $this->token);
+        $this->setupEnvironment(queryParamJwt: $this->token);
 
         $mock = $this->getMockBuilder($this->classname)
             ->disableOriginalConstructor()

test/SSOData/SSODataTest.php

@@ -14,6 +14,7 @@
 
 namespace Staffbase\plugins\test\SSOData;
 
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Staffbase\plugins\sdk\SSOData\SharedDataTrait;
 use Staffbase\plugins\sdk\SSOData\SSODataTrait;
@@ -25,31 +26,6 @@ class SSODataTest extends TestCase
      *
      * Test accessors deliver correct values.
      *
-     * @covers \Staffbase\plugins\sdk\SSOData\SharedDataTrait::getAudience()
-     * @covers \Staffbase\plugins\sdk\SSOData\SharedDataTrait::getExpireAtTime()
-     * @covers \Staffbase\plugins\sdk\SSOData\SharedDataTrait::getNotBeforeTime()
-     * @covers \Staffbase\plugins\sdk\SSOData\SharedDataTrait::getIssuedAtTime()
-     * @covers \Staffbase\plugins\sdk\SSOData\SharedDataTrait::getId()
-     * @covers \Staffbase\plugins\sdk\SSOData\SharedDataTrait::getIssuer()
-     * @covers \Staffbase\plugins\sdk\SSOData\SharedDataTrait::getSubject()
-     * @covers \Staffbase\plugins\sdk\SSOData\SharedDataTrait::getRole()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getInstanceId()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getInstanceName()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getUserId()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getUserExternalId()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getUserUsername()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getUserPrimaryEmailAddress()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getFullName()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getFirstName()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getLastName()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getType()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getThemeTextColor()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getThemeBackgroundColor()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getLocale()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getTags()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getBranchId()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getTags()
-     * @covers \Staffbase\plugins\sdk\SSOData\SSODataTrait::getSessionId()
      */
     public function testAccessorsGiveCorrectValues(): void
     {
@@ -86,12 +62,11 @@ public function testAccessorsGiveCorrectValues(): void
     /**
      * Test isEditor return correct values.
      *
-     * @covers \Staffbase\plugins\sdk\SSOToken::isEditor
      */
     public function testIsEditorReturnsCorrectValues(): void
     {
-
         $map = [
+            /** @phpstan-ignore array.duplicateKey */
             null => false,
             '' => false,
             'use' => false,
@@ -129,7 +104,6 @@ public function testIsEditorReturnsCorrectValues(): void
     /**
      * Test getData return correct values.
      *
-     * @covers \Staffbase\plugins\sdk\SSOToken::getData
      */
     public function testGetDataReturnsCorrectValues(): void
     {

test/SSOTokenTest.php

@@ -189,33 +189,6 @@ public function testConstructorToFailOnMissingInstanceId()
      *
      * Test accessors deliver correct values.
      *
-     * @covers \Staffbase\plugins\sdk\SSOToken::__construct
-     * @covers \Staffbase\plugins\sdk\SSOToken::getAudience()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getExpireAtTime()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getNotBeforeTime()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getIssuedAtTime()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getIssuer()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getId()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getInstanceId()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getInstanceName()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getUserId()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getUserExternalId()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getUserUsername()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getUserPrimaryEmailAddress()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getFullName()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getFirstName()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getLastName()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getRole()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getType()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getThemeTextColor()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getThemeBackgroundColor()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getLocale()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getTags()
-     * @covers \Staffbase\plugins\sdk\SSOToken::hasClaim()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getClaim()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getBranchId()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getBranchSlug()
-     * @covers \Staffbase\plugins\sdk\SSOToken::getSessionId()
      */
     public function testAccessorsGiveCorrectValues()
     {