Skip to content
This repository was archived by the owner on Apr 27, 2019. It is now read-only.

Commit 10480db

Browse files
author
El Sif
committed
remove single use method #load_dependencies. now loads them in place in #activate_plugin().
1 parent e7113aa commit 10480db

1 file changed

Lines changed: 2 additions & 13 deletions

File tree

plugin_manager.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -142,18 +142,6 @@ def resolve_dependencies(self, dependency_hash):
142142
self.logger.critical(str(e))
143143

144144

145-
def load_dependencies(self, dependent_name, dependencies):
146-
"""
147-
Loads plugin dependencies onto instance method #plugins of dependent.
148-
149-
:param dependent_name: Name of dependent plugin.
150-
:param dependencies: Dictionary of dependencies.
151-
:return: None
152-
"""
153-
for plugin in dependencies:
154-
self.plugin_classes[dependent_name].plugins[plugin.name] = plugin
155-
156-
157145
def load_plugins(self, plugins_to_load):
158146
"""
159147
Loads and instantiates plugins that it is asked to.
@@ -183,7 +171,8 @@ def activate_plugins(self, plugins, dependencies):
183171
self.plugins[plugin.name] = plugin()
184172
self.logger.debug("Instantiated plugin '%s'" % plugin.name)
185173
if len(plugin.depends) > 0:
186-
self.load_dependencies(plugin.name, [ self.plugins[x] for x in dependencies[plugin.name] ])
174+
for p in [ self.plugins[x] for x in dependencies[plugin.name] ]:
175+
self.plugin_classes[plugin.name].plugins[p.name] = p
187176
self.plugins[plugin.name].activate()
188177
except FatalPluginError as e:
189178
self.logger.critical("A plugin reported a fatal error. Error: %s", str(e))

0 commit comments

Comments
 (0)