[142] Added unit test for ChatLogger

Author: 8r2y5

plugins/announcer_plugin/announcer_plugin.py

@@ -7,9 +7,6 @@ class Announcer(BasePlugin):
     """
     name = 'announcer_plugin'
 
-    def activate(self):
-        super(Announcer, self).activate()
-
     def after_connect_success(self, data):
         self.factory.broadcast(
             '{} logged in.'.format(

plugins/chat_logger/chat_logger.py

@@ -10,9 +10,8 @@ class ChatLogger(BasePlugin):
 
     def on_chat_sent(self, data):
         parsed = chat_sent().parse(data.data)
-        parsed.message = parsed.message.decode('utf-8')
         self.logger.info(
             'Chat message sent: <%s> %s',
             self.protocol.player.name,
-            parsed.message
+            parsed.message.decode('utf-8')
         )

plugins/chat_logger/test_chat_logger.py

@@ -0,0 +1,27 @@
+from unittest import TestCase
+
+from mock import Mock, patch
+
+from plugins.chat_logger.chat_logger import ChatLogger
+
+
+class ChatLoggerTestCase(TestCase):
+
+    @patch('plugins.chat_logger.chat_logger.chat_sent')
+    def test_on_chat_sent(self, mock_chat_sent):
+        mock_data = Mock(data='data data')
+        mock_parsed = Mock()
+        mock_parsed.parse.return_value = Mock(message='test message')
+        mock_chat_sent.return_value = mock_parsed
+        mock_logger = Mock()
+        mock_protocol = Mock()
+        mock_protocol.player.name = 'player name'
+        plugin = ChatLogger()
+        plugin.protocol = mock_protocol
+        plugin.logger = mock_logger
+
+        plugin.on_chat_sent(mock_data)
+        mock_parsed.parse.assert_called_with('data data')
+        mock_logger.info.assert_called_with(
+            'Chat message sent: <%s> %s', 'player name', 'test message'
+        )