Skip to content
This repository was archived by the owner on Apr 27, 2019. It is now read-only.

Commit d5eeaf1

Browse files
committed
Unit tests, mapping overrdden packets.
1 parent 8bc385b commit d5eeaf1

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

base_plugin.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class MapOverridePacketsMethods(type):
1212

1313
def __new__(cls, name, bases, cls_dict):
1414
if name != 'BasePlugin':
15-
cls_dict['override_packets'] = {}
15+
cls_dict['overridden_packets'] = {}
1616
methods = (
1717
key for key, value in cls_dict.iteritems()
1818
if key not in cls.ignored_methods and callable(value)
@@ -23,7 +23,7 @@ def __new__(cls, name, bases, cls_dict):
2323
packet_name = packet.group('packet_name').upper()
2424
enum = getattr(Packets, packet_name, None)
2525
if enum:
26-
cls_dict['override_packets'].setdefault(
26+
cls_dict['overridden_packets'].setdefault(
2727
enum.value, {}
2828
)[packet.group('when')] = packet_method_name
2929

@@ -61,9 +61,9 @@ class BasePlugin(object):
6161
def __init__(self, *args, **kwargs):
6262
super(BasePlugin, self).__init__(*args, **kwargs)
6363
if self.__class__.__name__ != 'BasePlugin':
64-
for packet, when_dict in self.override_packets.iteritems():
64+
for packet, when_dict in self.overridden_packets.iteritems():
6565
for when, packet_name in when_dict.iteritems():
66-
self.override_packets[packet][when] = getattr(
66+
self.overridden_packets[packet][when] = getattr(
6767
self, packet_name
6868
)
6969

plugin_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ def map_plugin_packets(self, plugin):
272272
"""
273273
Maps plugin overridden packets ready to use in do method.
274274
"""
275-
for packet_id, when_dict in plugin.override_packets.iteritems():
275+
for packet_id, when_dict in plugin.overridden_packets.iteritems():
276276
for when, packet_method in when_dict.iteritems():
277277
self.packets.setdefault(
278278
packet_id, {}

0 commit comments

Comments
 (0)