Skip to content
This repository was archived by the owner on Apr 27, 2019. It is now read-only.

Commit e14ea4a

Browse files
committed
[PEP8] PacketStream
1 parent 039b02e commit e14ea4a

1 file changed

Lines changed: 43 additions & 17 deletions

File tree

packet_stream.py

Lines changed: 43 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,15 @@
66

77

88
class Packet(object):
9-
def __init__(self, packet_id, payload_size, data, original_data, direction, compressed=False):
9+
def __init__(
10+
self,
11+
packet_id,
12+
payload_size,
13+
data,
14+
original_data,
15+
direction,
16+
compressed=False
17+
):
1018
self.id = packet_id
1119
self.payload_size = payload_size
1220
self.data = data
@@ -19,7 +27,7 @@ class PacketStream(object):
1927
logger = logging.getLogger('starrypy.packet_stream.PacketStream')
2028

2129
def __init__(self, protocol):
22-
self._stream = ""
30+
self._stream = ''
2331
self.id = None
2432
self.payload_size = None
2533
self.header_length = None
@@ -52,44 +60,62 @@ def start_packet(self):
5260
self.compressed = True
5361
else:
5462
self.compressed = False
55-
self.header_length = 1 + len(packets.SignedVLQ("").build(packet_header.payload_size))
63+
self.header_length = 1 + len(packets.SignedVLQ('').build(
64+
packet_header.payload_size)
65+
)
5666
self.packet_size = self.payload_size + self.header_length
5767
return True
5868
except RuntimeError:
59-
self.logger.error("Unknown error in start_packet.")
69+
self.logger.error('Unknown error in start_packet.')
6070
return False
6171

6272
def check_packet(self):
6373
try:
64-
if self.packet_size is not None and len(self._stream) >= self.packet_size:
65-
p, self._stream = self._stream[:self.packet_size], self._stream[self.packet_size:]
74+
if (
75+
self.packet_size is not None and
76+
len(self._stream) >= self.packet_size
77+
):
78+
p = self._stream[:self.packet_size]
79+
self._stream = self._stream[self.packet_size:]
6680
if not self._stream:
67-
self._stream = ""
81+
self._stream = ''
6882
p_parsed = packets.packet().parse(p)
6983
if self.compressed:
7084
try:
7185
z = zlib.decompressobj()
7286
p_parsed.data = z.decompress(p_parsed.data)
7387
except zlib.error:
74-
self.logger.error("Decompression error in check_packet.")
75-
self.logger.debug("Parsed packet:")
88+
self.logger.error(
89+
'Decompression error in check_packet.'
90+
)
91+
self.logger.debug('Parsed packet:')
7692
self.logger.debug(pprint.pformat(p_parsed))
77-
self.logger.debug("Packet data:")
78-
self.logger.debug(pprint.pformat(p_parsed.original_data.encode("hex")))
79-
self.logger.debug("Following packet data:")
80-
self.logger.debug(pprint.pformat(self._stream.encode("hex")))
93+
self.logger.debug('Packet data:')
94+
self.logger.debug(
95+
pprint.pformat(
96+
p_parsed.original_data.encode('hex')
97+
)
98+
)
99+
self.logger.debug('Following packet data:')
100+
self.logger.debug(
101+
pprint.pformat(self._stream.encode('hex'))
102+
)
81103
raise
82-
packet = Packet(packet_id=p_parsed.id, payload_size=p_parsed.payload_size, data=p_parsed.data,
83-
original_data=p, direction=self.direction)
104+
packet = Packet(
105+
packet_id=p_parsed.id,
106+
payload_size=p_parsed.payload_size,
107+
data=p_parsed.data,
108+
original_data=p,
109+
direction=self.direction
110+
)
84111

85112
self.compressed = False
86113
self.protocol.string_received(packet)
87114
self.reset()
88115
if self.start_packet():
89116
self.check_packet()
90117
except RuntimeError:
91-
self.logger.error("Unknown error in check_packet")
92-
#return False
118+
self.logger.error('Unknown error in check_packet')
93119

94120
def reset(self):
95121
self.id = None

0 commit comments

Comments
 (0)