[Issue #14] - Checking builder.shouldBuild() is not idempotent

Author: DrewImm

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Fixes
 
+- [Issue #14] - Checking builder.shouldBuild() is not idempotent
 - [Issue #13] - html-to-app fails if out-of-source build, with -f, and dist folder already existing
 - [Issue #12] - html-to-app -c should kill program after creating config file
 

lib/index.js

@@ -113,6 +113,9 @@ if (cli.args.createConfig) {
 // Append properties to payload
 payload.build.force = cli.args.forceBuild;
 
+// Check if we need to build
+let shouldBuild = builder.shouldBuild() || cli.args.forceBuild;
+
 // Start the engine
 console.log("Importing...");
 executeCommand(importer.precmd);
@@ -125,7 +128,7 @@ importer.run(payload)
     })
     .then((payload) => {
         executeCommand(converter.postcmd);
-        if (builder.shouldBuild() || cli.args.forceBuild) {
+        if (shouldBuild) {
             executeCommand(builder.precmd);
             console.log("Building...");
             return builder.run(payload);
@@ -136,7 +139,7 @@ importer.run(payload)
         }
     })
     .then((payload) => {
-        if (builder.shouldBuild() || cli.args.forceBuild) {
+        if (shouldBuild) {
             executeCommand(builder.postcmd);
         }
         executeCommand(exporter.precmd);