Remove module state

Author: DrewImm

README.md

@@ -6,7 +6,7 @@ This package enhances typescript error handling, meaning easier troubleshooting
 - Customizable stack traces
 - Set stack trace limit
 - Set stack trace to "Just my Code"
-- Provides a overridable global error handler
+- Sets global uncaught global error handlers
 
 ## Setup
 
@@ -17,7 +17,7 @@ This package enhances typescript error handling, meaning easier troubleshooting
 **Usage**
 
 ```typescript
-import { setupErrorHandling, handler } from 'ts-error-handler';
+import { setupErrorHandling } from 'ts-error-handler';
 
 // Setup error handling options
 setupErrorHandling({
@@ -26,34 +26,31 @@ setupErrorHandling({
 })
 
 // Example:
-try {
-	// Throw an error
-	throw new Error('Help!');
-}
-catch (e) {
-	// Send the error to the handler
-	handler(e);
-}
+throw new Error('Help!');
 ```
 
 **With ts-async-bootstrap**
 
 ```typescript
 import { bootstrap } from 'ts-async-bootstrap';
-import { setupErrorHandling, handler } from 'ts-error-handler';
+import { setupErrorHandling } from 'ts-error-handler';
 
 import { register, main } from './somewhere-else';
 
+function errorHandler(e: Error): void {
+	console.error('Error!', e);
+}
+
 // Setup error handling
 setupErrorHandling({
-	handler: (e) => console.error('Error!', e)
+	handler: errorHandler
 });
 
 // Pass handler from ts-error-handler to bootstrap()
 bootstrap({
 	register: register,
 	run: main,
-	errorHandler: handler
+	errorHandler: errorHandler
 });
 ```
 
@@ -75,3 +72,7 @@ Set to true to show node-modules in stack traces when justMyCode is on
 **justMyCodeIncludeInternals**
 
 Set to true to show node-internals in stack traces when justMyCode is on
+
+**handler**
+
+Global error handler for uncaught exceptions/promise-rejections. Default is `console.error`

src/handler-function.ts

@@ -0,0 +1,4 @@
+/**
+ * A handler function takes an Error and returns void
+ */
+export type HandlerFunction = (e: Error) => void;

src/index.ts

@@ -8,37 +8,7 @@ if (!process[Symbol.for('ts-node.register.instance')]) {
 	});
 }
 
-/**
- * Global error handler
- */
-
-/**
- * A handler function takes an Error and returns void
- */
-export type HandlerFunction = (e: Error) => void;
-
-/**
- * Default error handler
- *
- * @param e
- */
-let _handler: HandlerFunction = (e: Error) => {
-	// eslint-disable-next-line no-console
-	console.error('Unhandled', e);
-	process.exit(1);
-};
-
-export const handler: HandlerFunction = (e: Error) => _handler(e);
-
-export function setHandler(f: HandlerFunction): void {
-	_handler = f;
-}
-
-/**
- * Register global handler for uncaught errors
- */
-process.on('uncaughtException', handler);
-process.on('unhandledRejection', handler);
+import { HandlerFunction } from 'handler-function';
 
 /**
  * Options for setupErrorHandling
@@ -68,6 +38,7 @@ export const defaultOptions: ErrorHandlerOptions = {
 	justMyCode: true,
 	justMyCodeIncludeNodeModules: false,
 	justMyCodeIncludeInternals: false,
+	handler: console.error
 };
 
 /**
@@ -78,6 +49,12 @@ export const defaultOptions: ErrorHandlerOptions = {
 export function setupErrorHandling(options: Partial<ErrorHandlerOptions>) {
 	options = { ...defaultOptions, ...options };
 
+	/**
+	 * Register global handler for uncaught errors
+	 */
+	process.on('uncaughtException', options.handler);
+	process.on('unhandledRejection', options.handler);
+
 	/**
 	 * Stack traces
 	 */
@@ -107,8 +84,4 @@ export function setupErrorHandling(options: Partial<ErrorHandlerOptions>) {
 				.join('\n');
 		};
 	}
-
-	if (options.handler) {
-		setHandler(options.handler);
-	}
 }

test/spec/index.spec.ts

@@ -1,5 +1,5 @@
 import 'jasmine';
-import { handler, setHandler, setupErrorHandling } from '../../src';
+import { setupErrorHandling } from '../../src';
 
 import { getStackTrace } from '../util/get-stack-trace';
 
@@ -15,26 +15,4 @@ describe('index', () => {
 		expect(trace).not.toContain('node_modules');
 		expect(trace).not.toContain('internal/');
 	});
-
-	it('allows setting an error handler', () => {
-		let err = null;
-
-		setHandler(e => err = e);
-		handler(new Error('test error'));
-
-		expect(err.message).toBe('test error');
-	});
-
-	it('allows setting handler function from setup', () => {
-		const spy = { on: () => {} };
-		spyOn(spy, 'on');
-
-		setupErrorHandling({
-			handler: spy.on
-		});
-
-		handler(new Error());
-
-		expect(spy.on).toHaveBeenCalled();
-	});
 });